Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): bump graphql from 15.7.2 to 16.2.0; run [GitHub] #7428

Closed
wants to merge 2 commits into from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Dec 24, 2021

Bumps graphql from 15.7.2 to 16.2.0.

Release notes

Sourced from graphql's releases.

v16.2.0 (2021-12-17)

New Feature 馃殌

Docs 馃摑

Polish 馃拝

  • #3423 assertName-test: test new instead of deprecated function (@鈥婥ito)

Internal 馃彔

Committers: 2

v16.1.0 (2021-12-07)

New Feature 馃殌

Bug Fix 馃悶

Docs 馃摑

Polish 馃拝

... (truncated)

Commits
  • 3ab82f4 16.2.0
  • f17351c assertName-test: test new instead of deprecated function (#3423)
  • 7795192 gh/actions: run benchmark and NPM diff on correct base commits (#3427)
  • 95a85f7 type/definition: export resolve*Thunk functions (#3426)
  • 4f56285 Minor grammar fixes in collectFields documentation (#3422)
  • c8bbb0a resources/utils: extract 'writeGeneratedFile' to utils (#3420)
  • 90bd6ff 16.1.0
  • ab52ddc package.json: Specify NPM release tag explicitly (#3417)
  • 763c149 fix c8 ignore decorator typos (#3416)
  • 6e48d16 ci: add check for unnessary duplicates in package-lock.json (#3407)
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [graphql](https://github.com/graphql/graphql-js) from 15.7.2 to 16.2.0.
- [Release notes](https://github.com/graphql/graphql-js/releases)
- [Commits](graphql/graphql-js@v15.7.2...v16.2.0)

---
updated-dependencies:
- dependency-name: graphql
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added the dependencies Related to dependency updates label Dec 24, 2021
@PyvesB PyvesB changed the title chore(deps): bump graphql from 15.7.2 to 16.2.0 chore(deps): bump graphql from 15.7.2 to 16.2.0; run [GitHub] Jan 8, 2022
@PyvesB
Copy link
Member

PyvesB commented Jan 8, 2022

Part of the fix was easy, simply removing some trailing newlines in our test assertions due to graphql/graphql-js#2997.

However; there's still an error:

Error: Cannot find module 'graphql/polyfills/objectValues'

My understanding is that Gatsby, which relies on an older version of GraphQL, uses functionality that was dropped in version 16.0.0: graphql/graphql-js#2919

Unless someone has a fancy trick in mind, I think we'll have to wait for Gatsby to catch up.

@calebcartwright
Copy link
Member

Unless someone has a fancy trick in mind, I think we'll have to wait for Gatsby to catch up.

Think that's right. We've been in a place for a little while now where we've got some conflicting needs between dependencies (primarily gatsby, eslint, and this one IIRC)

@chris48s
Copy link
Member

chris48s commented Jan 9, 2022

There's some notes in #7230 (comment) from when I last looked at this, but basically yeah I think we are blocked on this one for the moment. Similar to eslint 8

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Jan 28, 2022

A newer version of graphql exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged.

@calebcartwright
Copy link
Member

No reason to leave this open, #7624 (comment)

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Feb 19, 2022

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot dependabot bot deleted the dependabot/npm_and_yarn/graphql-16.2.0 branch February 19, 2022 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Related to dependency updates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants