Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update README to use slightly shorter apollo check #334

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update README to use slightly shorter apollo check #334

wants to merge 1 commit into from

Conversation

callumgare
Copy link

In the ApolloServer docs they recommend different url to use as a health check which is slightly shorter.

bahmutov
bahmutov requested changes Dec 5, 2022
View reviewed changes
Copy link
Owner

@bahmutov bahmutov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ughh I don't like it, I think the URL encoding makes it harder to understand what is requested

@callumgare
Copy link
Author

Up to you, personally I find
start-server-and-test commands tend to be quite long especially when there are multiple URLs involved which to me is the bigger readability issue. But if you prefer this as it is then feel free to close this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bahmutov bahmutov bahmutov requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@callumgare @bahmutov