Oracle: Move query methods to linked library #749
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facuspagnuolo
approved these changes
Jul 26, 2021
Comment on lines
42
to
43
| using Buffer for uint256; | ||
| using Samples for bytes32; |
There was a problem hiding this comment.
Do we still need these?
facuspagnuolo
changed the title
TomAFrench
added a commit
that referenced
this pull request
Aug 10, 2021
* master: renamed RewardsCallback -> DistributorCallback, and callback -> distributorCallback for added specificity (#776) Distributors: Exiter (#719) de-overload stake function to stakeFor a recipient (#767) MultiRewards: use authorizer pattern for access control (#752) Distributors: IRewardsCallback (#761) meta: emit price rate provider event in consturctor (#764) docs: fix _priceRate natspec to refer to a single token rather than list (#762) feat: add AssetHelpers class (#728) Investment pool v1 (#738) Deployments: Implement meta stable pool factory task (#759) Meta: Reduce bytecodesize below limit (#758) Chore: Fix deployment bytecode benchmark (#757) Meta: Index and test events (#755) Meta: Add factory tests (#754) Oracle: Fix linter (#753) Meta: Implement factory (#751) Oracle: Move query methods to linked library (#749) Meta: Add update cache event (#750) Fix WeightedPool2Tokens ABI docs: comment changes in MetaStablePool (#747)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reduces the bytecode size of MetaStablePools enough that they can be deployed. With 200 runs, they end up at 23.919kB.
The way bytecode is reduced is by removing all oracle query functionality outside of the pool contract itself, and into a linked library. This adds a slight overhead of ~3k gas (2600 from the
delegatecall), but gets rid of the binary search code and exponentiation (fromfromLowResLog).Ideally, we'd be able to deploy the library at construction time in either the Pool or the Factory. Unfortunately, Solidity does not allow for this (though I'll create a language proposal soon with this idea). Some available options are:
delegatecallis not consideredview) - essentially implementing a kind of proxy pattern. This could work, but it requires a way to keep the storage slots of the base and library contracts in syncviewcalls back into the main contract for storage reads. Even if these repeated calls only cost 100 gas, the overhead of call encoding, decoding, function dispatch, return value encoding and decoding quickly adds up.In the end, I went with 1), as this is the most 'standard' approach. I modified the
deployfunction to allow for libraries, which are manually linked. Unfortunately, Hardhat does not support linking an artifact directly (see NomicFoundation/hardhat#1716), so this will have to make do for now.This PR is split into two commits. The first moves functionality from the pool and oracle into the
QueryProcessorlibrary, while the second moves the query tests from the pools into the pool oracle, which is where they are implemented. No funtionality should change as a result of this.