Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BREAKING CHANGE: The exports from @testing-library/react has been removed #8

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

balavishnuvj
Copy link
Owner

This library uses @testing-library/dom and exports from it.

What:

It supports any library that uses screen from @testing-library/dom

Why:

To support sister testing libraries like @testing-library/react, @testing-library/vue etc

How:

Move the screen import from @testing-library/react to @testing-library/dom

Checklist:

  • Documentation
  • Tests
  • Ready to be merged

…oved.

This library uses @testing-library/dom and exports from it.
@codecov-io
Copy link

Codecov Report

Merging #8 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master        #8   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines           17        17           
  Branches         2         2           
=========================================
  Hits            17        17           
Impacted Files Coverage Δ
src/simple-queries.js 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e5ec80b...12ef980. Read the comment docs.

Copy link

@jacobparis jacobparis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've been testing this out with Vue for a week now and works well with no issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants