feat: support interpreting no-label issue as invalid

balazsorban44 · Feb 12, 2024 · af6911b · af6911b
1 parent a322004
commit af6911b
Show file tree

Hide file tree

Showing 5 changed files with 16 additions and 15 deletions.
diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
@@ -17,7 +17,7 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - name: Nissuer
-        uses: balazsorban44/nissuer@1.8.2
+        uses: balazsorban44/nissuer@1.9.0
         with:
           label-area-section: 'Which area\(s\) are affected\?(.*)'
-          reproduction-issue-labels: 'bug,'
+          reproduction-issue-labels: "bug,"
diff --git a/README.md b/README.md
@@ -23,14 +23,14 @@ nissuer comes with a default configuration, but you can override certain behavio
 - nissuer can close/comment/label/lock issues that do not have a valid reproduction URL
 - nissuer validates the returned status code of a reproduction URL (for example a private GitHub repository will not be considered valid)
 
-| Input                        | Description                                                                                                                                 | Default Value                                  |
-| ---------------------------- | ------------------------------------------------------------------------------------------------------------------------------------------- | ---------------------------------------------- |
-| `reproduction-comment`       | Either a string or a path to a .md file inside the repository.                                                                              | `.github/invalid-reproduction.md`              |
-| `reproduction-hosts`         | Comma-separated list of hostnames allowed for reproductions.                                                                                | `github.com`                                   |
-| `reproduction-blocklist`     | Comma-separated list of regular expression string that are not allowed for reproductions. (Eg.: "github.com/.\*/fork-of-non-reproduction"') |                                                |
-| `reproduction-invalid-label` | Label to apply to issues without a valid reproduction.                                                                                      | `invalid-reproduction`                         |
-| `reproduction-issue-labels`  | Comma-separated list of issue labels. If configured, only verify reproduction URLs of issues with one of these labels present.              |                                                |
-| `reproduction-link-section`  | A regular expression string with "(.\*)" matching a valid URL in the issue body. The result is trimmed.                                     | `### Link to reproduction(.*)### To reproduce` |
+| Input                        | Description                                                                                                                                                                                          | Default Value                                  |
+| ---------------------------- | ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- | ---------------------------------------------- |
+| `reproduction-comment`       | Either a string or a path to a .md file inside the repository.                                                                                                                                       | `.github/invalid-reproduction.md`              |
+| `reproduction-hosts`         | Comma-separated list of hostnames allowed for reproductions.                                                                                                                                         | `github.com`                                   |
+| `reproduction-blocklist`     | Comma-separated list of regular expression string that are not allowed for reproductions. (Eg.: "github.com/.\*/fork-of-non-reproduction"')                                                          |                                                |
+| `reproduction-invalid-label` | Label to apply to issues without a valid reproduction.                                                                                                                                               | `invalid-reproduction`                         |
+| `reproduction-issue-labels`  | Comma-separated list of issue labels. If configured, only verify reproduction URLs of issues with one of these labels present. A comma at the end will handle issues without any label as non-valid. |                                                |
+| `reproduction-link-section`  | A regular expression string with "(.\*)" matching a valid URL in the issue body. The result is trimmed.                                                                                              | `### Link to reproduction(.*)### To reproduce` |
 
 ### Label Management
 
@@ -78,7 +78,7 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - name: Nissuer
-        uses: balazsorban44/nissuer@1.8.2
+        uses: balazsorban44/nissuer@1.9.0
 ```
 
 Add a comment file (by default we look for `.github/invalid-reproduction.md`):

diff --git a/action.yml b/action.yml
@@ -25,7 +25,7 @@ inputs:
     description: 'Label to apply to issues without a valid reproduction. Example: "invalid-reproduction"'
     default: 'invalid-reproduction'
   reproduction-issue-labels:
-    description: 'Comma-separated list of issue labels. If configured, only verify reproduction URLs of issues with one of these labels present. Example: "bug"'
+    description: 'Comma-separated list of issue labels. If configured, only verify reproduction URLs of issues with one of these labels present. Adding a comma at the end will handle non-labeled issues as invalid. Example: "bug,", will consider issues with the label "bug" or no label.'
     default: ''
   reproduction-link-section:
     description: 'A regular expression string with "(.*)" matching a valid URL in the issue body. The result is trimmed. Example: "### Link to reproduction(.*)### To reproduce"'

diff --git a/dist/index.js b/dist/index.js
diff --git a/index.js b/index.js
@@ -82,8 +82,9 @@ async function checkValidReproduction() {
   const labels = issue.labels.map((l) => l.name)
 
   if (
-    config.invalidLink.bugLabels.length &&
-    !labels.some((l) => config.invalidLink.bugLabels.includes(l))
+    (!labels.length && config.invalidLink.bugLabels.includes("")) ||
+    (config.invalidLink.bugLabels.length &&
+      !labels.some((l) => config.invalidLink.bugLabels.includes(l)))
   )
     return info("Not manually or already labeled")