Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update async dependency and migrate code accordingly. #1407

Merged
merged 1 commit into from Nov 10, 2016

Conversation

mikermcneil
Copy link
Member

No description provided.

@mikermcneil
Copy link
Member Author

After the update:

∑ kit deps
  @sailshq/lodash@3.10.2       428.03 KB  0.214 seconds
  deep-diff@0.3.4              74.72 KB   0.037 seconds
  bluebird@3.2.1               581.24 KB  0.29 seconds
  flaverr@1.0.0                849.14 KB  0.424 seconds
  waterline-criteria@1.0.1     869.64 KB  0.434 seconds
  waterline-schema@0.2.0       913.68 KB  0.456 seconds
  switchback@2.0.1             877.02 KB  0.438 seconds
  async@2.0.1                  1.81 MB    0.909 seconds
  anchor@0.11.3  (~0.11.2)     3.74 MB    1.872 seconds
  prompt@1.0.0                 1.21 MB    0.609 seconds

Altogether, dependencies weigh in at 11.37 MB
(that will take an average of 5.68 seconds on coffee shop internet)

 (Note that `devDependencies` and `optionalDependencies` were NOT included above.)

Unfortunately, async@2 adds a bit of extra weight to the install. But for most people, it's a difference of about 0.8 seconds, so not worth looking into further right now. For more on that, see: caolan/async#1283 (comment)

@mikermcneil mikermcneil merged commit b515404 into master Nov 10, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
1 participant