Allow more lenient gzip decompression #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klutchell
force-pushed
the
klutchell/gzip-sync-flush
branch
from
2ef127a
to
2eaba19
Compare
klutchell
changed the title
Be more lenient with decoding compressed responses, since (very rarely) servers send slightly invalid gzip responses that are still accepted by common browsers. Always using Z_SYNC_FLUSH is what cURL does. Change-type: patch Signed-off-by: Kyle Harding <kyle@balena.io>
klutchell
force-pushed
the
klutchell/gzip-sync-flush
branch
from
2eaba19
to
9c7bc30
Compare
Page-
approved these changes
Aug 27, 2021
ghost
merged commit
zwhitchcox
added a commit
to balena-io-modules/balena-image-manager
that referenced
this pull request
Sep 5, 2021
Fixes [EOF zlib issue](balena-io/balena-cli#2152 ) per [@klutchell 's balena-request fix](balena-io-modules/balena-request#156). See: https://github.com/madler/zlib/blob/master/FAQ#L33 Change-type: minor
zwhitchcox
added a commit
to balena-io-modules/balena-image-manager
that referenced
this pull request
Sep 5, 2021
Fixes [EOF zlib issue](balena-io/balena-cli#2152 ) per [@klutchell 's balena-request fix](balena-io-modules/balena-request#156). See https://github.com/madler/zlib/blob/master/FAQ#L33 Change-type: minor
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Be more lenient with decoding compressed responses, since (very rarely)
servers send slightly invalid gzip responses that are still accepted
by common browsers.
Always using Z_SYNC_FLUSH is what cURL does.
Change-type: patch
Signed-off-by: Kyle Harding kyle@balena.io
Related upstream PR: request/request#2492