Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to pkg 5 #2436

Merged
1 commit merged into from
Jan 6, 2022
Merged

Update to pkg 5 #2436

1 commit merged into from
Jan 6, 2022

Conversation

Page-
Copy link
Contributor

@Page- Page- commented Jan 4, 2022

Change-type: patch

Resolves: #
Change-type: major|minor|patch
Depends-on:
See:


Please check the CONTRIBUTING.md file for relevant information and some
guidance. Keep in mind that the CLI is a cross-platform application that runs
on Windows, macOS and Linux. Tests will be automatically run by balena CI on
all three operating systems, but this will only help if you have added test
code that exercises the modified or added feature code.

Note that each commit message (currently only the first line) will be
automatically copied to the CHANGELOG.md file, so try writing it in a way
that describes the feature or fix for CLI users.

If there isn't a linked issue or if the linked issue doesn't quite match the
PR, please add a PR description to explain its purpose or the features that it
implements. Adding PR comments to blocks of code that aren't self explanatory
usually helps with the review process.

If the PR introduces security considerations or affects the development, build
or release process, please be sure to highlight this in the PR description.

Thank you very much for your contribution!

Change-type: patch
@ghost
Copy link

ghost commented Jan 4, 2022

Your landr site preview has been successfully deployed to https://landr-balena-io-repo-balena-cli-preview-2436.netlify.app

Deployed with Landr 7.1.0

@Page- Page- requested a review from pdcastro January 4, 2022 17:19
@Page-
Copy link
Contributor Author

Page- commented Jan 4, 2022

@pdcastro do you know which commands caused the

dyld: lazy symbol binding failed: Symbol not found: _napi_module_register
  Referenced from: /var/folders/1s/52g85bgj3wlchqh6szld3fp40000gn/T/f2e40016d01c60e8913da09524e6322533f0a40147a7871226a7f82bd016a877/node.napi.node
  Expected in: flat namespace

dyld: Symbol not found: _napi_module_register
  Referenced from: /var/folders/1s/52g85bgj3wlchqh6szld3fp40000gn/T/f2e40016d01c60e8913da09524e6322533f0a40147a7871226a7f82bd016a877/node.napi.node
  Expected in: flat namespace

errors you saw before?

@pdcastro
Copy link
Contributor

pdcastro commented Jan 4, 2022

do you know which commands caused the [...] errors you saw before?

I think the list would have included commands such as os configure, preload, local flash, login with web authorisation, logs with local IP address and push to local IP address, but I have now tested all of these commands between Linux and macOS with the draft standalone zip package produced by this PR, and all those commands worked OK. 🎉

The Symbol not found issue may have been fixed by pkg v5.3.2 (11 Sep 2021) that bumped pkg-fetch to v3.2.3, based on issues vercel/pkg/issues/1155 and vercel/pkg-fetch/pull/215.

Thanks for this work, @Page- 👏

@Page- Page- marked this pull request as ready for review January 6, 2022 16:22
@Page-
Copy link
Contributor Author

Page- commented Jan 6, 2022

@balena-ci rebase

@ghost ghost merged commit 5f2d55f into master Jan 6, 2022
@ghost ghost deleted the update-pkg branch January 6, 2022 17:27
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants