fix(CLI): get rid of Browserify absolute path workaround #1449
Conversation
| # module errors when executing it in another computer. | ||
| # The fix is to replace absolute paths with `__dirname` | ||
| node <<EOF > "$ARGV_OUTPUT.TMP" | ||
| const separator = process.platform === 'win32' ? '\\\\\\\\\\\\\\\\' : '\\/'; |
There was a problem hiding this comment.
Yay, bye bye megabackslashosaurus :-)
|
@lurch We had an older browserify version listed as a development dependency. My fork is running the latest one, which triggered some updated dependencies :) |
|
Do you need to update this PR to point to the new changes you made on browserify/browserify#1725 ? EDIT: To clarify my question...
but in and https://github.com/jviotti/node-browserify/commit/6ea4c1bd395e86a754131d547c29cc9dffd05b38 is a commit from before the most recent fix on that branch https://github.com/jviotti/node-browserify/commit/14691ac9257063000e4aa216073cdad28b9d04e1 |
We encountered a Browserify bug when releasing the CLI, where absolute paths would be hard-coded in the final bundle. Since we were in the middle of a release process, we added a quick and dirty search-and-replace workaround on `concatenate-javascript.sh`. After the release, we submitted a PR to Browserify which fixes the issue. This commit makes use of my personal fork to be able to use such fix while it gets merged to the main project. See: browserify/browserify#1725 See: #1409 Fixes: #1429 Signed-off-by: Juan Cruz Viotti <jviotti@openmailbox.org>
|
Fixed! |
jviotti
force-pushed
the
browserify-workaround-fork-fix
branch
from
23e5a0a
to
0179813
Compare
We encountered a Browserify bug when releasing the CLI, where absolute
paths would be hard-coded in the final bundle. Since we were in the
middle of a release process, we added a quick and dirty
search-and-replace workaround on
concatenate-javascript.sh.After the release, we submitted a PR to Browserify which fixes the
issue. This commit makes use of my personal fork to be able to use such
fix while it gets merged to the main project.
See: browserify/browserify#1725
See: #1409
Fixes: #1429
Signed-off-by: Juan Cruz Viotti jviotti@openmailbox.org