Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid an indefinite recursion that grows the call stack when reporting the current state fails #480

Merged
2 commits merged into from
Nov 3, 2017
Merged

Avoid an indefinite recursion that grows the call stack when reporting the current state fails #480

2 commits merged into from
Nov 3, 2017

Commits on Nov 2, 2017

  1. Avoid an indefinite recursion that grows the call stack when reportin… 

    …g the current state fails

We used to have a recursion based on Promises and Promise.delay, which caused the promise never to resolve
so eventually the stack would be exhausted.

This fixes it by using a simpler way to check if reporting the state is in progress and using a setImmediate to
call applyState outside of the Promise chain.

Change-Type: patch
Signed-off-by: Pablo Carranza Velez <pablo@resin.io>
    Pablo Carranza Velez committed Nov 2, 2017
    Configuration menu
    Copy the full SHA
    51d6ab0 View commit details
    Browse the repository at this point in the history

Commits on Nov 3, 2017

  1. v6.4.2

    resin-io-versionbot[bot] authored and VersionBot committed Nov 3, 2017
    Configuration menu
    Copy the full SHA
    a3b5b03 View commit details
    Browse the repository at this point in the history