Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move overlapping to strategyType and remove it from strategySettings #1201

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Move overlapping to strategyType and remove it from strategySettings #1201

wants to merge 4 commits into from
+29 −24

Conversation

tiagofilipenunes
Copy link
Collaborator

@tiagofilipenunes tiagofilipenunes commented May 3, 2024 •
edited

Fix #1007

  • Do not enforce strategySettings to be present in searchParams as 'range' will be the fallback
  • Overlapping deeplinks no longer showing strategyType=recurring&strategySettings=overlapping
  • Strategy type in CreateStrategyOrders now showing as 'Overlapping' when creating an overlapping strategy and not 'Recurring'
  • Fix issues with limit and range strategySettings searchParam (especially on refresh)

@cloudflare-pages Cloudflare Pages
Copy link

cloudflare-pages bot commented May 3, 2024 •
edited

Deploying carbon-app-sei with  Cloudflare Pages  Cloudflare Pages

Latest commit: 74f6f29
Status: ✅  Deploy successful!
Preview URL: https://82c3755b.carbon-app-sei.pages.dev
Branch Preview URL: https://issue--1007.carbon-app-sei.pages.dev

View logs

@cloudflare-pages Cloudflare Pages
Copy link

cloudflare-pages bot commented May 3, 2024 •
edited

Deploying carbon-app with  Cloudflare Pages  Cloudflare Pages

Latest commit: 74f6f29
Status: ✅  Deploy successful!
Preview URL: https://c3475a17.carbon-app-csq.pages.dev
Branch Preview URL: https://issue--1007.carbon-app-csq.pages.dev

View logs

@tiagofilipenunes tiagofilipenunes marked this pull request as draft May 3, 2024 19:47
@tiagofilipenunes tiagofilipenunes marked this pull request as ready for review May 16, 2024 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Overlapping] Creating an overlapping strategy shows 'Recurring' strategy type in strategy creation page
1 participant
@tiagofilipenunes