Show unknown market price warning #1209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
tiagofilipenunes
commented
May 8, 2024
tiagofilipenunes
commented
- Check market price is unknown in useWarning
- Add warning text to LimitRangeSection to use in non-overlapping strategies
- Check market price is unknown in useWarning - Add warning text to LimitRangeSection to use in non-overlapping strategies
Deploying carbon-app-sei with
|
| Latest commit: |
d41f5f0
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://3f6e7baf.carbon-app-sei.pages.dev |
| Branch Preview URL: | https://unknown-market-price-warning.carbon-app-sei.pages.dev |
Deploying carbon-app with
|
| Latest commit: |
d41f5f0
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://bc5e56c4.carbon-app-csq.pages.dev |
| Branch Preview URL: | https://unknown-market-price-warning.carbon-app-csq.pages.dev |
2 tasks
- If price is not available, center the graph in the middle of the max and min prices - If the price is not available, hide the market price in the graph - If the price is not available, hide the price-source text
- Remove getMarketPrice and use useMarketPrice in DebugCreateStrategy - Replace comparisons of marketPrice with 0 by checks if undefined - Adjust Overlapping Graph to remove percentage above and below when there is no price
src/components/strategies/overlapping/OverlappingStrategyGraph.tsx
Outdated
Show resolved
Hide resolved
src/components/strategies/overlapping/OverlappingStrategyGraph.tsx
Outdated
Show resolved
Hide resolved
src/components/strategies/overlapping/OverlappingStrategyGraph.tsx
Outdated
Show resolved
Hide resolved
….tsx Co-authored-by: François <francois.guezengar@hotmail.fr>
- Calculate market price percentage inside OverlappingStrategyGraph - Pass external and old market price in deposit and withdrawal - Change price source checks and add geometric mean text
src/components/strategies/edit/overlapping/DepositOverlappingStrategy.tsx
Outdated
Show resolved
Hide resolved
src/components/strategies/overlapping/OverlappingStrategyGraph.tsx
Outdated
Show resolved
Hide resolved
- If disabled, prefer external price over market price - If enabled, prefer user price over external price
GrandSchtroumpf
approved these changes
May 13, 2024
ashachaf
approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.