fix(search): restrict search field to names only #558
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
NameCN就是中文名 |
|
咦，那有点奇怪，现在好多条目即使是用完整的中文全称都搜不到的样子 |
|
可能是权重有点问题 |
|
理论上来说nameCn就是主站显示的中文名 |
|
可以考虑降低别名的权重，提高原标题和中文标题的权重 |
|
summary 现在看起来还是有点喧宾夺主，我看之前貌似是拿掉了的，但是没有生效的样子？ |
|
比如这个条目 https://bgm.tv/subject/264093 ，用日文全名搜索出来是第一个，但是中文全名就完全搜不到 |
|
前面定义的 |
everpcpc
changed the title
trim21
reviewed
May 26, 2024
internal/search/handle.go
Outdated
| @@ -169,6 +168,9 @@ func (c *client) doSearch( | |||
| } | |||
|
|
|||
| raw, err := c.subjectIndex.SearchRaw(words, &meilisearch.SearchRequest{ | |||
| AttributesToSearchOn: []string{ | |||
There was a problem hiding this comment.
如果这样的话就要改一下search able fields吧？没必要索引简洁了
这个选项改了之后我会重建的 |
|
这样一来tag还能搜索吗 |
|
应该不需要搜 tag？毕竟已经拿来 filter 了（而且其实现在 tag 里本身有效信息也比较少 |
|
server/internal/search/handle.go Line 63 in abb3ee4 |
|
这个应该是 filter 不是 search？ |
|
确实 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.