vault-env: fix logrus behaviour that sends all logst to stder #1729
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jespada
requested review from
bonifaido,
pbalogh-sa and
Rasek91
as code owners
akijakya
approved these changes
Dec 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
There is an ongoing issue with logrus and many other projects that relay on it report the same 1 2 , basically logrus will log to stderr things that should not be there and this is an issue since this get parsed incorrectly.
This PR uses logrus write hooks to send them to the correct place.
Why?
It make any log parsing and aggregation tool to behaves correctly.
Additional context
Checklist