Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: switch to generic secrets webhook #2529

Merged
merged 4 commits into from
May 15, 2024
Merged

feat: switch to generic secrets webhook #2529

merged 4 commits into from
May 15, 2024

Conversation

csatib02
Copy link
Member

@csatib02 csatib02 commented Feb 29, 2024 •
edited

Overview

  • This PR changes Vault-env and vault-secrets-webhookreferences to secret-init and secrets-webhook references.

@csatib02
chore: change vault-env references to secret-init
6ddc463 
Signed-off-by: Bence Csati <bcsati@cisco.com>
@csatib02 csatib02 self-assigned this Feb 29, 2024
@csatib02 csatib02 requested a review from a team as a code owner February 29, 2024 14:35
@github-actions github-actions bot added the size/S Denotes a PR that changes 10-99 lines label Feb 29, 2024
@csatib02 csatib02 removed the request for review from a team February 29, 2024 15:13
@csatib02 csatib02 added kind/feature Categorizes issue or PR as related to a new feature. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Feb 29, 2024
akijakya
akijakya requested changes Mar 13, 2024
View reviewed changes
Copy link
Contributor

@akijakya akijakya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work so far! 💪

ADOPTERS.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@csatib02
chore: fix remarks
b97e7db 
Signed-off-by: Bence Csati <bcsati@cisco.com>
@github-actions github-actions bot added size/XS Denotes a PR that changes 0-9 lines and removed size/S Denotes a PR that changes 10-99 lines labels Mar 13, 2024
@csatib02
chore: fix remarks
8ca9fc6 
Signed-off-by: Bence Csati <bcsati@cisco.com>
@csatib02 csatib02 requested a review from akijakya March 14, 2024 17:00
ramizpolic
ramizpolic previously approved these changes Apr 5, 2024
View reviewed changes
@ramizpolic ramizpolic added triage/on-hold Indicates an issue or PR is on hold for some reason. kind/regression Categorizes issue or PR as related to a regression from a prior release. labels Apr 5, 2024
@ramizpolic ramizpolic changed the title chore: change vault-env references to secret-init feat: switch go generic secrets webhook Apr 5, 2024
@ramizpolic ramizpolic changed the title feat: switch go generic secrets webhook feat: switch to generic secrets webhook Apr 5, 2024
ramizpolic
ramizpolic reviewed May 10, 2024
View reviewed changes
Makefile Show resolved Hide resolved
@csatib02
chore: remove webhook docker image
fdcf3c2 
Signed-off-by: Bence Csati <bcsati@cisco.com>
@csatib02 csatib02 merged commit 36ef28c into main May 15, 2024
20 checks passed
@csatib02 csatib02 deleted the chore/change-vault_env-refernces branch May 15, 2024 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ramizpolic ramizpolic ramizpolic approved these changes

@akijakya akijakya akijakya approved these changes

Assignees

@csatib02 csatib02

Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/feature Categorizes issue or PR as related to a new feature. kind/regression Categorizes issue or PR as related to a regression from a prior release. size/XS Denotes a PR that changes 0-9 lines triage/on-hold Indicates an issue or PR is on hold for some reason.
Projects
Project backlog
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@csatib02 @ramizpolic @akijakya