chore: bump go version #448
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csatib02
added
the
triage/on-hold
Signed-off-by: Bence Csati <bcsati@cisco.com>
csatib02
force-pushed
the
chore/bump-go-version-update-dependencies
branch
from
1ab167d
to
3b10cca
Compare
csatib02
changed the title
csatib02
removed
the
triage/on-hold
Signed-off-by: Bence Csati <bcsati@cisco.com>
github-actions
bot
added
size/XL
This was referenced May 6, 2024
ramizpolic
added
the
triage/on-hold
ramizpolic
changed the title
|
The pipeline (maybe NIX too) also need to be updated to use proper Go version |
This was referenced May 13, 2024
Signed-off-by: Bence Csati <bcsati@cisco.com>
csatib02
force-pushed
the
chore/bump-go-version-update-dependencies
branch
from
055cfae
to
546662c
Compare
Signed-off-by: Bence Csati <bcsati@cisco.com>
ramizpolic
reviewed
May 15, 2024
Comment on lines
+104
to
+106
| vault = pkgs.buildGoModule rec { | ||
| pname = "vault"; | ||
| version = "1.14.8"; |
There was a problem hiding this comment.
any specific reason why we are building vault package here?
There was a problem hiding this comment.
Forgot to add it to the services, now it works:
Signed-off-by: Bence Csati <bcsati@cisco.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Goversion to1.22.2.