Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the bug of arguments generation #190

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix the bug of arguments generation #190

wants to merge 2 commits into from

Conversation

noahingh
Copy link

@noahingh noahingh commented Nov 3, 2022

Q A
Bug fix? yes
New feature? no
API breaks? no
Deprecations? no
Related tickets fixes #189
License Apache 2.0

What's in this PR?

Fix the GetArgs function, which generates the arguments from the custom resource.

Why?

Fix the GetArgs function to handle the int and *bool type fields as the other types.

Checklist

  • Code meets the Developer Guide
  • User guide and development docs updated (if needed)
  • Related Helm chart(s) updated (if needed)

@noahingh noahingh marked this pull request as ready for review November 3, 2022 04:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Some arguments are missing from generation
1 participant
@noahingh