Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced GHA set-output with GITHUB_OUTPUT #191

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

pregnor
Copy link
Member

@pregnor pregnor commented Dec 6, 2022

Q A
Bug fix? no
New feature? no
API breaks? no
Deprecations? no
Related tickets -
License Apache 2.0

What's in this PR?

Replaced ::set-output with >> $GITHUB_OUTPUT

Why?

Deprecated, will be removed in 2023-05-31.

Additional context

Details: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/.

Tested in another PR, worked well.

Checklist

  • Implementation tested
  • Error handling code meets the guideline
  • Logging code meets the guideline
  • User guide and development docs updated (if needed)

Reason: deprecated, will be removed in 2023-05-31.

Details: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

Command: grep -R -l "::set-output" . | xargs -n 1 sed -E -i '' 's/"?::set-output name=([^:]+)::([^"]+)"?$/"\1=\2" >> $GITHUB_OUTPUT/g'
@pregnor pregnor requested a review from asdwsda December 6, 2022 17:49
@pregnor pregnor self-assigned this Dec 6, 2022
@pregnor
Copy link
Member Author

pregnor commented Dec 7, 2022

I see the sec scan is failing on independent things.
I also see things have been merged to master with this check failing.
Could one of the repo admins merge this as well or advise me how to fix the CI?

@pregnor pregnor requested a review from ahma December 13, 2022 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants