Skip to content

Commit

Permalink
Work-around modularity issues with okio (square/okio#1306)
Browse files Browse the repository at this point in the history
  • Loading branch information
barchetta committed Jul 26, 2023
1 parent 9f44fbe commit 605488c
Show file tree
Hide file tree
Showing 3 changed files with 15 additions and 0 deletions.
2 changes: 2 additions & 0 deletions applications/parent/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -105,6 +105,8 @@
<overWriteIfNewer>true</overWriteIfNewer>
<overWriteIfNewer>true</overWriteIfNewer>
<includeScope>runtime</includeScope>
<!-- Hack to work-around https://github.com/square/okio/issues/1306 -->
<excludeArtifactIds>okio</excludeArtifactIds>
</configuration>
</execution>
</executions>
Expand Down
7 changes: 7 additions & 0 deletions tracing/jaeger/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,13 @@
<scope>provided</scope>
<optional>true</optional>
</dependency>
<!-- Hack to get around module issue in okio. See module-info.java -->
<dependency>
<groupId>org.jetbrains.kotlin</groupId>
<artifactId>kotlin-stdlib</artifactId>
<version>1.8.0</version>
<scope>provided</scope>
</dependency>
<!--
- Test dependencies
-->
Expand Down
6 changes: 6 additions & 0 deletions tracing/jaeger/src/main/java/module-info.java
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,12 @@
requires io.helidon.common.context;
requires io.helidon.common.configurable;

// Hack because okhttp and okio are not modularized
// but kotlin.stdlib is, and therefore kotlin.stdlib
// will be missing from module graph unless some module
// requires it.
requires kotlin.stdlib;

requires static io.helidon.config.metadata;

requires java.logging;
Expand Down

0 comments on commit 605488c

Please sign in to comment.