docs: add performance considerations chapter #1597
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pstorz
force-pushed
the
dev/pstorz/master/docs-performance-compression
branch
from
354294e
to
0da5167
Compare
| - xfs on ssd partition | ||
| * - **Storage Filesystem** | ||
| - tmpfs 10G ramdisk | ||
|
|
There was a problem hiding this comment.
Should be nice to have the output of openssl testing test.
openssl speed md5 sha1 sha256 sha512
version: 3.1.4
options: bn(64,64)
compiler: gcc -fPIC -pthread -m64 -Wa,--noexecstack -Wall -O3 -O2 -Wall -U_FORTIFY_SOURCE -fstack-protector-strong -funwind-tables -fasynchronous-unwind-tables -fstack-clash-protection -Werror=return-type -flto=auto -g -Wa,--noexecstack -fno-common -Wall -DOPENSSL_USE_NODELETE -DL_ENDIAN -DOPENSSL_PIC -DOPENSSL_BUILDING_OPENSSL -DZLIB -DNDEBUG -D_FORTIFY_SOURCE=3 -DTERMIO -DPURIFY -D_GNU_SOURCE -DOPENSSL_NO_BUF_FREELISTS -DSYSTEM_CIPHERS_FILE="/etc/crypto-policies/back-ends/openssl.config"
CPUINFO: OPENSSL_ia32cap=0x7ffaf3ffffebffff:0x29c67af
The 'numbers' are in 1000s of bytes per second processed.
type 16 bytes 64 bytes 256 bytes 1024 bytes 8192 bytes 16384 bytes
md5 42047.62k 139503.13k 322998.78k 482274.30k 587265.37k 606262.61k
sha1 52591.86k 171246.51k 421058.82k 662665.56k 791098.71k 825567.91k
sha256 41911.55k 109063.49k 239631.24k 315815.59k 351338.50k 347586.56k
sha512 31209.98k 126040.62k 264445.44k 446635.35k 546570.24k 536024.41k
sebsura
requested changes
Nov 16, 2023
Comment on lines
+462
to
+465
|
|
||
| set(comp_algo "lz4hc") | ||
| set(checksum_algo "sha512") | ||
|
|
| Address = @hostname@ | ||
| Password = "@fd_password@" | ||
| Fd Port = @fd_port@ | ||
| } |
systemtests/tests/speed-test/defs
Outdated
Comment on lines
2
to
4
| # /testspace/pstorz/data_kernelsource | ||
| /testspace/pstorz/data_multimedia | ||
| # /testspace/pstorz/data_rootfs |
There was a problem hiding this comment.
The default here should probably be something that always exists.
| Only *LZO* and *No Compression* are regarded. | ||
|
|
||
|
|
||
| No TLS with no Encryption |
There was a problem hiding this comment.
Suggested change
| No TLS with no Encryption | |
| No TLS with no Compression |
|
|
||
| Speed comparison [MiB/s] when TLS is disabled and no compression is configured. | ||
|
|
||
| No TLS with LZO Encryption |
There was a problem hiding this comment.
Suggested change
| No TLS with LZO Encryption | |
| No TLS with LZO Compression |
sebsura
reviewed
Nov 16, 2023
| log="$restore_log-$clientoptions_filenamecompat-$filesetoptions_filenamecompat" | ||
| echo > "$log" | ||
| # clean restore dir | ||
| sudo rm -Rvf "$tmp/bareos-restores" |
There was a problem hiding this comment.
This is a very bad idea. I think the sudo is not supposed to be here ?
There was a problem hiding this comment.
Also there are a lot of complaints from shellcheck here.
With Python >= 3.12 the setuptools isn't available by default but have to be installed manually. (cherry picked from commit 921115f)
github actions: PyPi: install setuptools
We now also display a negative compression rate in the job log, before it was changed to "None". This is an important information as it suggests the administrator to disable compression.
This reverts commit df03c42.
This reverts commit e3898f3.
pstorz
force-pushed
the
dev/pstorz/master/docs-performance-compression
branch
from
cfe24c2
to
92e8487
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for contributing to the Bareos Project!
Please check
If you have any questions or problems, please give a comment in the PR.
Helpful documentation and best practices
Checklist for the reviewer of the PR (will be processed by the Bareos team)
Make sure you check/merge the PR using
devtools/pr-toolto have some simple automated checks run and a proper changelog record added.General
Source code quality
Tests