-
Notifications
You must be signed in to change notification settings - Fork 256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tools: add dedup estimation tool bdedupestimate
#1654
tools: add dedup estimation tool bdedupestimate
#1654
Conversation
bdedupestimate
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Create a manpage for bdedupestimate please.
f4a24a2
to
db878a4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wouldn't it make sense to have a system test that runs bdedupestimate?
f779e67
to
b178f01
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- dedup factor format should be
2.34x
(like ZFS does the output) and notx2.34
. See comment - Some commits still contain "Fixup"
b178f01
to
1ef2048
Compare
1ef2048
to
c3c347e
Compare
This tool should be able to estimate how much space saving you could achive by switching to a dedupable volume layout on a deduping file system.
With this flag enabled we match complete records instead of subdividing records into datablocks.
dedup_units can now have different sizes if record based dedup is enabled. As such we should only compare the sha results if the sizes are equal.
Now that records are split into multiple blocks to make deduplication useful even if backing up smaller files, we need to adjust the estimate logic to account for that.
f995f55
to
88652ef
Compare
Thank you for contributing to the Bareos Project!
This pr adds a tool with which you can estimate how much space you could save when using deduplication.
Please check
If you have any questions or problems, please give a comment in the PR.
Helpful documentation and best practices
Checklist for the reviewer of the PR (will be processed by the Bareos team)
Make sure you check/merge the PR using
devtools/pr-tool
to have some simple automated checks run and a proper changelog record added.General
Required backport PRs have been createdSource code quality
Tests