bscrypto: fix and update code, and move CLI parsing to cli11, add systemtests #1734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
17 tasks
sebsura
force-pushed
the
dev/alaaeddineelamri/master/bscsicrypto-to-CLI11
branch
from
4fa2675
to
d4fed3d
Compare
bruno-at-bareos
force-pushed
the
dev/alaaeddineelamri/master/bscsicrypto-to-CLI11
branch
from
0b584fb
to
1862889
Compare
`bstrncpy` makes sure the destination string is always null terminated, which results in the last character of the string being replaced with `0` which in turn makes the passphrase string missing its last character.
Remove the hardcoded 1 to explicit STDOUT_FILENO
to redirect job messages to stdout
passphrase is not a cstring (no null terminator) so it cannot be printed with %s; bstrncpy can copy length + 1 bytes but only length bytes were allocated; etc.
- cmake scsi-crypto option can be ON by default, it is only triggered if tapes device are present. - systemtests: cleanup cryptoc cache file. Signed-off-by: Bruno Friedmann <bruno.friedmann@bareos.com>
- Fix ScsicryptoSd call in bareos-config - developerFAQ: quote tapedevice list Without the quote example in copy and paste call the second and beyond tape drives are called by sh (due to ; separator) Signed-off-by: Bruno Friedmann <bruno.friedmann@bareos.com>
Those tests will be activated with cmake autochanger and tapes drives flag is present in cojunction with -Dscsi-crypto=ON. We use quadstore-vtl to test and design the tests. - add vtl functions to global scripts - systemtests: remove obsolete plugin option values
bruno-at-bareos
force-pushed
the
dev/alaaeddineelamri/master/bscsicrypto-to-CLI11
branch
from
1862889
to
6268389
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bscrypto
This PR moves CLI parsing of bscrypto to CLI11, along with some code updates and refactoring.
We also add a specific systemtest
and review the related documentation
It will certainly need a backport to 23.
this is based on the old #1350
Please check
If you have any questions or problems, please give a comment in the PR.
Helpful documentation and best practices
Checklist for the reviewer of the PR (will be processed by the Bareos team)
Make sure you check/merge the PR using
devtools/pr-toolto have some simple automated checks run and a proper changelog record added.General
Source code quality
Tests