Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dird: disallow running always incremental virtual full jobs with empty jobid list #1738

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

sebsura
Copy link
Contributor

@sebsura sebsura commented Mar 15, 2024

Thank you for contributing to the Bareos Project!

This PR prevents users from accidentally trying to restart a virtualfull job when always incremental is enabled.
Restarting a virtualfull job in that setting used to combine all backup points into one which is not what you want.

This also removes traces of the unfinished legacy feature 'fdcalled'.

Please check

  • Short description and the purpose of this PR is present above this paragraph
  • Your name is present in the AUTHORS file (optional)

If you have any questions or problems, please give a comment in the PR.

Helpful documentation and best practices

Checklist for the reviewer of the PR (will be processed by the Bareos team)

Make sure you check/merge the PR using devtools/pr-tool to have some simple automated checks run and a proper changelog record added.

General
  • Is the PR title usable as CHANGELOG entry?
  • Purpose of the PR is understood
  • Commit descriptions are understandable and well formatted
  • Check backport line
  • Required backport PRs have been created
Source code quality
  • Source code changes are understandable
  • Variable and function names are meaningful
  • Code comments are correct (logically and spelling)
  • Required documentation changes are present and part of the PR
Tests
  • Decision taken that a test is required (if not, then remove this paragraph)
  • The choice of the type of test (unit test or systemtest) is reasonable
  • Testname matches exactly what is being tested
  • On a fail, output of the test leads quickly to the origin of the fault

We should not run if always incremental is set but no jobids are given
since this will otherwise cause the VF to consolidate ALL the current
jobs into one full, which is definitely not what you want.
Sometimes -1 is returned on error, and sometimes 0 is returned.  Now
it always returns -1 on error.
@sebsura sebsura force-pushed the dev/ssura/master/fix-ai-vf-with-no-jobid branch from 38be77f to 46e5026 Compare March 15, 2024 06:26
@arogge arogge added this to the 24.0.0 milestone Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants