windows: fix some crashes, change handling of invalid paths; lex: add better error detection; accurate: fix out of bounds writes #1793
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Our win32-cross toolchain does not handle thread_local correctly. This can load to crashes because it may free the storage before destructing the object inside the storage. See here for reference: https://sourceforge.net/p/mingw-w64/bugs/727/ This is extremely easy to reproduce if run in a debugger (gdb in my case). In the wild this does not happen 100%. As such thread_local was replaced by a manually managed pthread_key.
In the trace of one customer we saw the fd try to add a single file multiple times! This is a work around for that.
sebsura
force-pushed
the
dev/ssura/master/fix-windows-crash
branch
from
15dd02e
to
9708140
Compare
Add simple tests that check that accurate does not do weird things even if the database has inconsistencies.
sebsura
force-pushed
the
dev/ssura/master/fix-windows-crash
branch
from
9708140
to
5b40ea3
Compare
sebsura
force-pushed
the
dev/ssura/master/fix-windows-crash
branch
from
219655b
to
9c03a19
Compare
|
This has fixed issues encountered in support ticket 75261. |
sebsura
force-pushed
the
dev/ssura/master/fix-windows-crash
branch
2 times, most recently
from
5d68c76
to
0799099
Compare
sebsura
commented
May 16, 2024
sebsura
commented
May 16, 2024
Comment on lines
+79
to
+83
| jobid=$(cat "$log_home/backup-jobid.out" | grep "jobid" | tail -n1 | cut -d':' -f2 | cut -d'"' -f2) | ||
|
|
||
| # make the director miscount the number of files | ||
| cat <<END_OF_DATA >"$tmp/bconcmds" | ||
| @$out $log_home/query.out |
There was a problem hiding this comment.
add test for lmdb as well + add doc string for lmdb options.
Adds a systemtest that checks some parser behaviours. This needs to be a systemtest as some parser errors lead to aborts/exits and cannot be run in unit tests as such.
Also print how many files are expected to be sent
Since we are supposed to send pktsiz many bytes, we should also print that number in case we did not send everything, otherwise we may run into situations where message_length == sent bytes != pktsiz (which happened at a customer) and the message does not make sense anymore.
sebsura
force-pushed
the
dev/ssura/master/fix-windows-crash
branch
from
0799099
to
9859d90
Compare
pstorz
requested changes
May 28, 2024
| @@ -0,0 +1,3 @@ | |||
| .. note:: | |||
| These worker threads are mostly used to compute checksums, and to compress & encrypt data. | |||
| If this is set to at least 1, then bareos will use a seperate thread for sending data. | |||
There was a problem hiding this comment.
Suggested change
| If this is set to at least 1, then bareos will use a seperate thread for sending data. | |
| If this is set to at least 1, bareos will use a separate thread for sending data. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for contributing to the Bareos Project!
This PR contains the following changes:
/usr/bin/sendmailon windowsSHGetFolderPathbySHGetKnownFolderPathPlease check
If you have any questions or problems, please give a comment in the PR.
Helpful documentation and best practices
Checklist for the reviewer of the PR (will be processed by the Bareos team)
Make sure you check/merge the PR using
devtools/pr-toolto have some simple automated checks run and a proper changelog record added.General
Source code quality
Tests