Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing DLL in windows packaging #1819

Merged
merged 4 commits into from
May 21, 2024

Conversation

arogge
Copy link
Member

@arogge arogge commented May 16, 2024

Backport of PR #1807 to bareos-21

Checklist for the reviewer of the PR (will be processed by the Bareos team)

Make sure you check/merge the PR using devtools/pr-tool to have some simple automated checks run and a proper changelog record added.

Source code quality (if there were changes to the original PR)
  • Source code changes are understandable
  • Variable and function names are meaningful
  • Code comments are correct (logically and spelling)
  • Required documentation changes are present and part of the PR

Backport quality

@arogge arogge linked an issue May 16, 2024 that may be closed by this pull request
@arogge arogge added this to the 21.1.10 milestone May 16, 2024
@arogge arogge requested a review from sebsura May 16, 2024 08:52
Copy link
Contributor

@sebsura sebsura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

(cherry picked from commit acec6c1)
replace /nonfatal file copies by conditional fatal ones
this makes sure don't accidentially skip files we wanted.
It also makes sure we don't like files that don't exist anymore.

(cherry picked from commit 34ac7df)
remove unused label

(cherry picked from commit dd6965c)
@arogge arogge force-pushed the backport/bareos-21/fix-traymon-win branch from 190cabc to 63454d2 Compare May 17, 2024 09:11
@BareosBot BareosBot merged commit 440c065 into bareos:bareos-21 May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix broken tray monitor on windows
3 participants