Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(webpack.dev.js): update source maps #10

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

moacode
Copy link

@moacode moacode commented Nov 17, 2020

Description

This PR improves dev build performance by turning off CSS source maps and setting JS source maps to use “eval-cheap-source-map”.

Fixes #4

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

I've tested the dev webpack setup locally combined with batchnz/craft#22

Turned off css source maps and set js source maps to use “eval-cheap-source-map” for performance.
@moacode moacode self-assigned this Nov 17, 2020
@moacode moacode mentioned this pull request Nov 17, 2020
1 task
Copy link
Contributor

@judereid judereid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one @thejoshsmith - looks good!

@rb1193
Copy link

rb1193 commented Nov 18, 2020

Does this provide useful source maps for Vue SFCs? If so I'm all for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve CSS build time
3 participants