Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix adequacy.py #843

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix adequacy.py #843

wants to merge 1 commit into from

Conversation

ycchen678
Copy link

Hello, and thanks for contributing to <%= name %>!

TL;DR

There are three main goals in this document, depending on the nature of your PR:

  • description: try to fix the problem that out-of-service locations still show providers.
  • checklist: review the checklist that is most closely related to your PR.
  • qa: added a couple of tests.

Title

fixing the problem that out-of-service locations still show providers
If it closes an issue, refer to it in your PR title by stating closes #117 at the end.

Description

To help others to quickly understand the nature of your pull request, please create a description that incorporates the following elements:

  • [] What is accomplished by the PR.
  • [] If you think some decisions may raise questions or require discussion, please state them and explain your choices.

Checklist

Please use this checklist to verify that you took all the necessary steps.

  • If closing an issue, all acceptance criteria are met.
  • All existing unit tests are still passing.
  • Add new passing unit tests to cover the code introduced by your PR and maintain test coverage.
  • Update the readme if needed.
  • Update or add any necessary API documentation.

QA

When your PR is created, it is important to select a reviewer with knowledge of the code that has been changed.
It is also useful to guide reviewers, to this extent, please complete this QA list with areas that could be affected by your changes.

Dear reviewer, please perform the following QA steps before approving my lovely PR:

  • The app loads nominally.
  • Select service area using the county selector.
  • Upload a service area csv (FIX DATASET).
  • Upload a provider csv (FIX DATASET).
  • Verify that NEW FEATRURE works as expected, i.e. DETAILS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant