Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default exports file to generate script (#1) #133

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

franverona
Copy link

@franverona franverona commented Aug 9, 2022

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Description

After many months using the package on several projects, I've found that having one line per import for each icon might be a little bit overwhelming regarding "import maintenance".

With this PR the package will generate an index.ts file with all icons exported as default. Thus, the following snippets are equivalent:

import {
  CloseLineIcon,
  EyeLineIcon,
  EyeOffLineIcon,
  SearchLineIcon
} from 'remixicon-react'
import CloseLineIcon from 'remixicon-react/CloseLineIcon'
import EyeLineIcon from 'remixicon-react/EyeLineIcon'
import EyeOffLineIcon from 'remixicon-react/EyeOffLineIcon'
import SearchLineIcon from 'remixicon-react/SearchLineIcon'

This change is Reviewable

@FelipeQueiroz
Copy link

This PR need's to be approved soon as possible, this change is very important for clean codes.

@franverona
Copy link
Author

Any chance that this will be merged soon?

@Liam26
Copy link

Liam26 commented Sep 28, 2023

Absolute wildcard here but I really wish we could get this merged in it would be so much better

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants