Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: stamp the version into the artifact #93

Merged
merged 1 commit into from
Sep 5, 2023
Merged

feat: stamp the version into the artifact #93

merged 1 commit into from
Sep 5, 2023

Conversation

alexeagle
Copy link
Contributor

@alexeagle alexeagle commented Sep 5, 2023 •
edited

This avoids the need for Publish To BCR to create patch files like bazel-contrib/publish-to-bcr#28 and reduces the clutter of module_dot_bazel.patch files in BCR

@alexeagle
feat: stamp the version into the artifact
ef40159 
This avoids the need for Publish To BCR to create patch files like bazel-contrib/publish-to-bcr#28
and reduces the clutter of module_dot_bazel.patch files in BCR
fmeum
fmeum reviewed Sep 5, 2023
View reviewed changes
Copy link
Member

@fmeum fmeum left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

N/A

MODULE.bazel Show resolved Hide resolved
@alexeagle alexeagle merged commit 7d0f586 into main Sep 5, 2023
7 checks passed
@alexeagle alexeagle deleted the rm_wksp branch September 5, 2023 20:58
alexeagle added a commit to aspect-build/bazel-lib that referenced this pull request Sep 5, 2023
@alexeagle
chore: pull in bazel-contrib/rules-template#93
cb88755 
This means we won't need a module_dot_bazel.patch file on BCR anymore
alexeagle added a commit to aspect-build/bazel-lib that referenced this pull request Sep 5, 2023
@alexeagle
chore: pull in bazel-contrib/rules-template#93 (#513)
f1e8407 
This means we won't need a module_dot_bazel.patch file on BCR anymore
alexeagle added a commit that referenced this pull request Sep 6, 2023
@alexeagle
Revert "feat: stamp the version into the artifact (#93)"
a5f4576 
This reverts commit 7d0f586.
alexeagle added a commit that referenced this pull request Sep 9, 2023
@alexeagle
Revert release automation tagging (#94)
de2e97d 
* Revert "fix: strip v prefix when copying tag into module version"

This reverts commit c37dffd.

* Revert "feat: stamp the version into the artifact (#93)"

This reverts commit 7d0f586.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fmeum fmeum fmeum left review comments

@kormide kormide kormide approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@alexeagle @fmeum @kormide