Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update protocol buffers blogpost for the deprecation of native Protobuf rules #191

Merged
merged 8 commits into from Oct 28, 2019

Conversation

Yannic
Copy link
Contributor

@Yannic Yannic commented Aug 4, 2019

Fixes #188

TODO before this can be merged:

@Yannic Yannic mentioned this pull request Aug 4, 2019
@Yannic
Copy link
Contributor Author

Yannic commented Aug 22, 2019

This change is ready for review (and for merging by the end of this week).
Thanks in advance

@Yannic Yannic marked this pull request as ready for review August 22, 2019 19:14
@jin
Copy link
Member

jin commented Aug 23, 2019

cc @lberki

@hlopko
Copy link
Member

hlopko commented Aug 26, 2019

Hi Yannic, in general, LGTM, I just couldn't for the life of me find the time to render this to verify its clean. Sorry for delays.

@aiuto
Copy link
Contributor

aiuto commented Oct 1, 2019

So, where do we stand on this? Do you like the text but want to make sure it renders correctly?
I can do the rendering test.

@aiuto
Copy link
Contributor

aiuto commented Oct 1, 2019

It renders fine. Can you add a pointer back to it.

file: _posts/2019-10-01-protobuf-updates.md
======== snip =============

layout: posts
title: "Protobuf instructions update."
authors:

  • Yannic

Updated instructions for using Protocol Buffers in Bazel
======== snip =============

@Yannic
Copy link
Contributor Author

Yannic commented Oct 1, 2019

@aiuto thanks! done, ptal.

@Yannic
Copy link
Contributor Author

Yannic commented Oct 18, 2019

Friendly ping?

@aiuto aiuto merged commit 2183125 into bazelbuild:master Oct 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update protobuf blog post
4 participants