New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
protobuf@27.0-rc2 #1982
protobuf@27.0-rc2 #1982
Conversation
Hello @bazelbuild/bcr-maintainers, modules without existing maintainers (protobuf) have been updated in this PR. Please review the changes. |
@alexeagle Do you know how the extra I tried removing the spurious line in my latest commit but looks like it still fails validation: https://buildkite.com/bazel/bcr-presubmit/builds/5311#018f5e4e-92bf-48e2-9759-365059be2888 Sidenote: Looks like release successfully triggers this PR from publish-to-br-bot! Thanks for your contribution here! |
@kormide is the person to ask. I think it's a publish-to-bcr bug that it adds a |
Thanks -- removed from the PR. I can probably update our version line to remove the const instead although we use this to make things easier for our version updaters. Would a comment on this line interfere with the tooling? e.g.
Per chat, sounds like it can also handle the following as well?
|
@fmeum Can you take another look at this change? Note, I had to remove debian 10 from presubmit.yml due to a warning being treated as an error by c11plus -- is there a way to simply disable warnings from being treated as errors here? |
You can pass flags just as in regular Bazel CI. There are no defaults beyond what Bazel's or your repo's C++ toolchains provide, so I'm a bit surprised to see this. |
bazel_dep(name = "platforms", version = "0.0.8") | ||
bazel_dep(name = "zlib", version = "1.2.11") | ||
|
||
# TODO: remove after toolchain types are moved to protobuf |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this really the plan? Afaik toolchain types can't be aliased, so this would be somewhat painful.
Release: https://github.com/protocolbuffers/protobuf/releases/tag/v27.0-rc2
Automated by Publish to BCR