Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

protobuf@27.0-rc2 #1982

Conversation

publish-to-bcr-bot[bot]
Copy link
Contributor

@bazel-io
Copy link
Member

bazel-io commented May 8, 2024

Hello @bazelbuild/bcr-maintainers, modules without existing maintainers (protobuf) have been updated in this PR. Please review the changes.

@fmeum fmeum added presubmit-auto-run Presubmit jobs will be triggered for new changes automatically without reviewer's approval skip-url-stability-check Skip the URL stability check for the PR labels May 8, 2024
@zhangskz
Copy link
Contributor

zhangskz commented May 9, 2024

@alexeagle Do you know how the extra version = v27.0-rc2 is coming from? MODULE.bazel looks right in v27.0-rc2 afaict: https://github.com/protocolbuffers/protobuf/blob/v27.0-rc2/MODULE.bazel

I tried removing the spurious line in my latest commit but looks like it still fails validation: https://buildkite.com/bazel/bcr-presubmit/builds/5311#018f5e4e-92bf-48e2-9759-365059be2888

Sidenote: Looks like release successfully triggers this PR from publish-to-br-bot! Thanks for your contribution here!

@alexeagle
Copy link
Contributor

@kormide is the person to ask. I think it's a publish-to-bcr bug that it adds a version field instead of modifying the one that's there, probably because it's referencing a constant and every other module uses a string literal as the version value

@zhangskz
Copy link
Contributor

Thanks -- removed from the PR. I can probably update our version line to remove the const instead although we use this to make things easier for our version updaters. Would a comment on this line interfere with the tooling?

e.g.

version = "27.0-rc2" # com_google_protobuf version

Per chat, sounds like it can also handle the following as well?

version = "0.0.0"

@zhangskz
Copy link
Contributor

@fmeum Can you take another look at this change?

Note, I had to remove debian 10 from presubmit.yml due to a warning being treated as an error by c11plus -- is there a way to simply disable warnings from being treated as errors here?

@fmeum
Copy link
Contributor

fmeum commented May 14, 2024

Note, I had to remove debian 10 from presubmit.yml due to a warning being treated as an error by c11plus -- is there a way to simply disable warnings from being treated as errors here?

You can pass flags just as in regular Bazel CI. There are no defaults beyond what Bazel's or your repo's C++ toolchains provide, so I'm a bit surprised to see this.

bazel_dep(name = "platforms", version = "0.0.8")
bazel_dep(name = "zlib", version = "1.2.11")

# TODO: remove after toolchain types are moved to protobuf
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this really the plan? Afaik toolchain types can't be aliased, so this would be somewhat painful.

@fmeum fmeum enabled auto-merge (squash) May 14, 2024 21:47
@fmeum fmeum merged commit cb9f1fc into bazelbuild:main May 14, 2024
18 checks passed
@zhangskz zhangskz deleted the protocolbuffers/protobuf@v27.0-rc2-632dfd21 branch May 14, 2024 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
presubmit-auto-run Presubmit jobs will be triggered for new changes automatically without reviewer's approval skip-url-stability-check Skip the URL stability check for the PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants