Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

emsdk@3.1.8 #2015

Closed
wants to merge 2 commits into from
Closed

emsdk@3.1.8 #2015

wants to merge 2 commits into from

Conversation

@bazel-io
Copy link
Member

Hello @bazelbuild/bcr-maintainers, modules without existing maintainers (emsdk) have been updated in this PR. Please review the changes.

@fmeum fmeum added presubmit-auto-run Presubmit jobs will be triggered for new changes automatically without reviewer's approval skip-url-stability-check Skip the URL stability check for the PR labels May 12, 2024
@mmorel-35
Copy link
Contributor Author

Hi @zaucy ,
I see that you've been contributing to this project.
Any guidance on how to proceed with this project ?
I used an old version because this is the actually used version

@mmorel-35 mmorel-35 marked this pull request as draft May 12, 2024 10:10
@zaucy
Copy link
Contributor

zaucy commented May 13, 2024

I haven't used it with bzlmod yet. I've only been using the workspace instructions (https://github.com/emscripten-core/emsdk/tree/main/bazel). Adding to WORKSPACE.bzlmod works fine for my current usage, but I'm sure they would love bzlmod support upstream. I'd recommend first trying to add support there instead of adding a patch to the BCR.

@mmorel-35 mmorel-35 closed this May 17, 2024
@mmorel-35 mmorel-35 deleted the emsdk@3.1.8 branch May 19, 2024 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
presubmit-auto-run Presubmit jobs will be triggered for new changes automatically without reviewer's approval skip-url-stability-check Skip the URL stability check for the PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants