Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jwt_verify_lib@0.0.0-20230517-b59e807 #2016

Merged

Conversation

mmorel-35
Copy link
Contributor

@mmorel-35 mmorel-35 commented May 12, 2024

@bazel-io
Copy link
Member

Hello @bazelbuild/bcr-maintainers, modules without existing maintainers (jwt_verify_lib) have been updated in this PR. Please review the changes.

@mmorel-35 mmorel-35 force-pushed the jwt_verify_lib@0.0.0-202230517-b59e807 branch 3 times, most recently from b9fcf6c to 6786d1b Compare May 12, 2024 11:27
@mmorel-35 mmorel-35 marked this pull request as draft May 12, 2024 11:37
@mmorel-35 mmorel-35 force-pushed the jwt_verify_lib@0.0.0-202230517-b59e807 branch 2 times, most recently from 4154e07 to d18590a Compare May 12, 2024 11:43
@mmorel-35 mmorel-35 marked this pull request as ready for review May 12, 2024 11:46
@mmorel-35 mmorel-35 force-pushed the jwt_verify_lib@0.0.0-202230517-b59e807 branch 5 times, most recently from 21694cb to 9666a1d Compare May 12, 2024 12:54
@fmeum fmeum added presubmit-auto-run Presubmit jobs will be triggered for new changes automatically without reviewer's approval skip-url-stability-check Skip the URL stability check for the PR labels May 12, 2024
@fmeum
Copy link
Contributor

fmeum commented May 12, 2024

Blocked on a rules_fuzzing release with bazelbuild/rules_fuzzing#248.

@mmorel-35 mmorel-35 force-pushed the jwt_verify_lib@0.0.0-202230517-b59e807 branch 3 times, most recently from 5dd83b1 to 23c496f Compare May 12, 2024 13:59
@mmorel-35
Copy link
Contributor Author

I added the '--sandbox_block_path=/usr/local' as it is in the boringssl but I’m suprised it needs to be added here too

@mmorel-35 mmorel-35 force-pushed the jwt_verify_lib@0.0.0-202230517-b59e807 branch 2 times, most recently from b7fda26 to 8c7527e Compare May 14, 2024 08:35
@mmorel-35
Copy link
Contributor Author

Hi @fmeum ,
I updated the version of rules_fuzzing : https://github.com/bazelbuild/rules_fuzzing/releases/tag/v0.5.2
But it seems not available in the BCR yet. Is the bot not activated yet ?

@fmeum
Copy link
Contributor

fmeum commented May 14, 2024

The release failed because the archive is a zip, not a tar.gz. We'll have to submit it manually. I'm somewhat busy with the next Bazel release right now, so if you want it quicker, you could submit it and I can review it.

@mmorel-35 mmorel-35 force-pushed the jwt_verify_lib@0.0.0-202230517-b59e807 branch from 8c7527e to bdddb36 Compare May 15, 2024 09:42
@mmorel-35 mmorel-35 requested a review from fmeum May 15, 2024 09:42
@mmorel-35 mmorel-35 force-pushed the jwt_verify_lib@0.0.0-202230517-b59e807 branch from 352997d to 881ce3f Compare May 15, 2024 21:42
@mmorel-35 mmorel-35 changed the title jwt_verify_lib@0.0.0-202230517-b59e807 jwt_verify_lib@0.0.0-20230517-b59e807 May 15, 2024
@mmorel-35 mmorel-35 force-pushed the jwt_verify_lib@0.0.0-202230517-b59e807 branch from 881ce3f to cd968ec Compare May 15, 2024 21:44
@mmorel-35 mmorel-35 force-pushed the jwt_verify_lib@0.0.0-202230517-b59e807 branch from cd968ec to 9918ea3 Compare May 15, 2024 21:51
@mmorel-35 mmorel-35 requested a review from fmeum May 16, 2024 13:00
@fmeum fmeum merged commit 146b1bd into bazelbuild:main May 16, 2024
18 checks passed
@mmorel-35 mmorel-35 deleted the jwt_verify_lib@0.0.0-202230517-b59e807 branch May 16, 2024 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
presubmit-auto-run Presubmit jobs will be triggered for new changes automatically without reviewer's approval skip-url-stability-check Skip the URL stability check for the PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants