add a go_test directive to enable generating go_test targets per _test.go file #1597

shahms · 2023-08-02T16:53:05Z

What type of PR is this?
Feature

What package or component does this PR mostly affect?
language/go

What does this PR do? Why is it needed?
This adds a new directive controlling how go_test targets are generated. Specifically, it adds a new file mode, which will generate a go_test target for each _test.go file in a package, rather than a single go_test target containing all such files.

Which issues(s) does this PR fix?

Fixes #1594

Other notes for review

…t.go file

language/go/generate.go

language/go/package.go

language/go/testdata/tests_per_file/BUILD.want

shahms · 2023-08-11T20:37:12Z

Any further comments here?

fmeum · 2023-08-13T10:28:09Z

This looks good to me now, but I don't know the gazelle codebase well enough to be sure that this will behave correctly on updates (such as when switching test modes or adding new test files).

Could you perhaps add tests for these cases?

shahms · 2023-08-25T16:42:29Z

This looks good to me now, but I don't know the gazelle codebase well enough to be sure that this will behave correctly on updates (such as when switching test modes or adding new test files).

Could you perhaps add tests for these cases?

Done. Thanks!

fmeum

Thanks for the great test coverage!

fmeum · 2023-08-26T21:40:59Z

@shahms Could you resolve the merge conflicts and ping me afterwards?

shahms · 2023-08-28T14:47:55Z

@shahms Could you resolve the merge conflicts and ping me afterwards?

It looks like you took care of that? Thanks!

tyler-french · 2023-08-29T15:54:52Z

Something interesting is happening. When I use mode file to test (from the PR), I am getting nogo failures from a generated testmain.go from rules_go, which I think should be excluded by some convention (FYI @fmeum).

Trying to investigate why this is happening, but my guess is there needs to be an update to the logic nogo uses to skip this testmain.go file.

As this is an opt in, that doesn't necessarily mean this situation is release blocking.

shahms · 2023-08-30T14:59:53Z

Let me know if there's something more I can do to help :-)

fmeum · 2023-08-30T15:03:41Z

@sluongng Do you happen to have an idea why nogo triggers on testmain.go in this case?

sluongng · 2023-08-31T11:45:55Z

I think we are only excluding the content of the generated coverage code and empty files right now. Not testmain.go.

There are 2 ways to go about fixing it:

Make testmain.go template in-compliance with the linter
Adjust compilepkg.go to exclude testmain.go

I suspect the former would be easier, but I don't know the details of the analyzer @tyler-french is running in his repo.

If you choose the latter route, take a look at this variable usage to see how exclusion could be implemented. https://github.com/search?q=repo%3Abazelbuild%2Frules_go%20%2FnogoSrcsOrigin%2F&type=code

Regardless, @tyler-french it would be nice if you could help us add a test for this in either rules_go / gazelle or both. It would help us detect future regression earlier. Right now this PR is completely green and could be a very attractive target for merging. I know that @hawkingrei has been asking for something like this since they ran into Bazel shard count limitation (25?).

hawkingrei · 2023-09-06T02:55:25Z

I think we are only excluding the content of the generated coverage code and empty files right now. Not testmain.go.

There are 2 ways to go about fixing it:
* Make `testmain.go` template in-compliance with the linter

* Adjust compilepkg.go to exclude `testmain.go`
I suspect the former would be easier, but I don't know the details of the analyzer @tyler-french is running in his repo.

If you choose the latter route, take a look at this variable usage to see how exclusion could be implemented. https://github.com/search?q=repo%3Abazelbuild%2Frules_go%20%2FnogoSrcsOrigin%2F&type=code

Regardless, @tyler-french it would be nice if you could help us add a test for this in either rules_go / gazelle or both. It would help us detect future regression earlier. Right now this PR is completely green and could be a very attractive target for merging. I know that @hawkingrei has been asking for something like this since they ran into Bazel shard count limitation (25?).

Yes, we have too many test case in the bazel shard. It is a good way to help us to solve this problem.

BTW, we have many goleak in the main_test.go so we should add this file into go_test per _test.go file.

tyler-french · 2023-08-28T14:34:43Z

language/go/config.go

@@ -30,6 +29,8 @@ import (
 	"strconv"
 	"strings"

+	"github.com/bazelbuild/bazel-gazelle/internal/module"
+


Suggested change

nit

tyler-french · 2023-08-28T14:37:43Z

language/go/config.go

+	case fileTestMode:
+		return "file"
+	default:
+		log.Panicf("unknown mode %d", m)


Don't panic on a String(), since this is mostly used for fmt.Sprintf(. Instead, let's just say "unknown"

tyler-french · 2023-08-28T21:33:49Z

language/go/package.go

 	library, binary, test goTarget
+  tests                 []goTarget
 	proto                 protoTarget
 	hasTestdata           bool


nit: formatting

Suggested change

library, binary, test goTarget

tests []goTarget

proto protoTarget

hasTestdata bool

library, binary, test goTarget

tests []goTarget

proto protoTarget

hasTestdata bool

tyler-french · 2023-09-06T03:05:25Z

@fmeum @shahms Oops sorry didn't see that this was already merged. I agree, and think the maintest.go issue anyway is safe because this feature is guarded by a directive anyway. Nice work!

fmeum · 2023-09-06T10:18:26Z

@shahms If possible, could you address @tyler-french's comments in a follow-up PR?

shahms · 2023-09-06T15:17:40Z

Comments addressed in #1628

This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [bazel_gazelle](https://togithub.com/bazelbuild/bazel-gazelle) | http_archive | minor | `v0.32.0` -> `v0.33.0` | --- ### Release Notes <details> <summary>bazelbuild/bazel-gazelle (bazel_gazelle)</summary> ### [`v0.33.0`](https://togithub.com/bazelbuild/bazel-gazelle/releases/tag/v0.33.0) [Compare Source](https://togithub.com/bazelbuild/bazel-gazelle/compare/v0.32.0...v0.33.0) #### What's Changed - Generate BUILD files for grpc-gateway by default by [@seh](https://togithub.com/seh) in [bazelbuild/bazel-gazelle#1578 - Remove temporary workaround after rules_go 0.41.0 release by [@fmeum](https://togithub.com/fmeum) in [bazelbuild/bazel-gazelle#1577 - bzlmod: Use first host-compatible SDK to bootstrap Gazelle by [@fmeum](https://togithub.com/fmeum) in [bazelbuild/bazel-gazelle#1581 - Update: golang.org/x/exp & golang.org/x/oauth2 deps. by [@sfc-gh-ptabor](https://togithub.com/sfc-gh-ptabor) in [bazelbuild/bazel-gazelle#1582 - \[README.rst] Mention kotlin PoC by [@kolloch](https://togithub.com/kolloch) in [bazelbuild/bazel-gazelle#1590 - Fix and let `# gazelle:follow` accept a glob by [@shahms](https://togithub.com/shahms) in [bazelbuild/bazel-gazelle#1596 - Add support for isolated `go_deps` usages by [@fmeum](https://togithub.com/fmeum) in [bazelbuild/bazel-gazelle#1584 - feat(bzlmod): support archive_override in go_deps by [@tyler-french](https://togithub.com/tyler-french) in [bazelbuild/bazel-gazelle#1559 - fix: avoid updating `WORKSPACE` file when running `update-repos` when bzlmod is enabled by [@cgrindel](https://togithub.com/cgrindel) in [bazelbuild/bazel-gazelle#1589 - Make `go_deps.from_file` compatible with Go 1.21 by [@fmeum](https://togithub.com/fmeum) in [bazelbuild/bazel-gazelle#1605 - go_repository: fix missing default GOPROXY by [@sluongng](https://togithub.com/sluongng) in [bazelbuild/bazel-gazelle#1602 - fix: patch support for dir named workspace by [@michaellzc](https://togithub.com/michaellzc) in [bazelbuild/bazel-gazelle#1606 - Revert "go_repository: fix missing default GOPROXY ([#1602](https://togithub.com/bazelbuild/bazel-gazelle/issues/1602))" by [@sluongng](https://togithub.com/sluongng) in [bazelbuild/bazel-gazelle#1609 - Upgrade `golang.org/x/mod` Vendor to Support Go 1.21 by [@alan910127](https://togithub.com/alan910127) in [bazelbuild/bazel-gazelle#1611 - fix: go_repository: never shadow a module with a compatibility mapping for major versions. by [@reltuk](https://togithub.com/reltuk) in [bazelbuild/bazel-gazelle#1608 - bug fix: don't generate invalid go_binary rules for empty main packages by [@andyscott](https://togithub.com/andyscott) in [bazelbuild/bazel-gazelle#1618 - Fix wrong Kotlin Support link in README. by [@duckladydinh](https://togithub.com/duckladydinh) in [bazelbuild/bazel-gazelle#1619 - bzlmod: Verify that the lockfile is platform-independent by [@fmeum](https://togithub.com/fmeum) in [bazelbuild/bazel-gazelle#1617 - Add gazelle_rust under supported languages by [@Calsign](https://togithub.com/Calsign) in [bazelbuild/bazel-gazelle#1620 - replace golang.org/x/tools with golang.org/x/tools/go/vcs@v0.1.0-deprecated by [@malt3](https://togithub.com/malt3) in [bazelbuild/bazel-gazelle#1603 - Implement Merger interface by [@Whoaa512](https://togithub.com/Whoaa512) in [bazelbuild/bazel-gazelle#1569 - Improve Gazelle launcher's runfiles discovery on Windows by [@fmeum](https://togithub.com/fmeum) in [bazelbuild/bazel-gazelle#1604 - Add an entry for "github.com/googleapis/gax-go/v2" to default_gazelle_overrides.bzl by [@andrewmbenton](https://togithub.com/andrewmbenton) in [bazelbuild/bazel-gazelle#1623 - add a go_test directive to enable generating go_test targets per \_test.go file by [@shahms](https://togithub.com/shahms) in [bazelbuild/bazel-gazelle#1597 - Detect whether Gazelle itself is a Bazel module by [@fmeum](https://togithub.com/fmeum) in [bazelbuild/bazel-gazelle#1624 - prepare release 0.33 by [@tyler-french](https://togithub.com/tyler-french) in [bazelbuild/bazel-gazelle#1615 #### New Contributors - [@sfc-gh-ptabor](https://togithub.com/sfc-gh-ptabor) made their first contribution in [bazelbuild/bazel-gazelle#1582 - [@kolloch](https://togithub.com/kolloch) made their first contribution in [bazelbuild/bazel-gazelle#1590 - [@shahms](https://togithub.com/shahms) made their first contribution in [bazelbuild/bazel-gazelle#1596 - [@michaellzc](https://togithub.com/michaellzc) made their first contribution in [bazelbuild/bazel-gazelle#1606 - [@alan910127](https://togithub.com/alan910127) made their first contribution in [bazelbuild/bazel-gazelle#1611 - [@reltuk](https://togithub.com/reltuk) made their first contribution in [bazelbuild/bazel-gazelle#1608 - [@andyscott](https://togithub.com/andyscott) made their first contribution in [bazelbuild/bazel-gazelle#1618 - [@duckladydinh](https://togithub.com/duckladydinh) made their first contribution in [bazelbuild/bazel-gazelle#1619 - [@Calsign](https://togithub.com/Calsign) made their first contribution in [bazelbuild/bazel-gazelle#1620 - [@malt3](https://togithub.com/malt3) made their first contribution in [bazelbuild/bazel-gazelle#1603 - [@andrewmbenton](https://togithub.com/andrewmbenton) made their first contribution in [bazelbuild/bazel-gazelle#1623 **Full Changelog**: bazelbuild/bazel-gazelle@v0.32.0...v0.33.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://togithub.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate).  Co-authored-by: Self-hosted Renovate Bot <361546+cgrindel-self-hosted-renovate[bot]@users.noreply.github.enterprise.com>

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [bazel_gazelle](https://togithub.com/bazelbuild/bazel-gazelle) | http_archive | minor | `v0.32.0` -> `v0.33.0` | --- ### ⚠ Dependency Lookup Warnings ⚠ Warnings were logged while processing this repo. Please check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>bazelbuild/bazel-gazelle (bazel_gazelle)</summary> ### [`v0.33.0`](https://togithub.com/bazelbuild/bazel-gazelle/releases/tag/v0.33.0) [Compare Source](https://togithub.com/bazelbuild/bazel-gazelle/compare/v0.32.0...v0.33.0) #### What's Changed - Generate BUILD files for grpc-gateway by default by [@seh](https://togithub.com/seh) in [bazelbuild/bazel-gazelle#1578 - Remove temporary workaround after rules_go 0.41.0 release by [@fmeum](https://togithub.com/fmeum) in [bazelbuild/bazel-gazelle#1577 - bzlmod: Use first host-compatible SDK to bootstrap Gazelle by [@fmeum](https://togithub.com/fmeum) in [bazelbuild/bazel-gazelle#1581 - Update: golang.org/x/exp & golang.org/x/oauth2 deps. by [@sfc-gh-ptabor](https://togithub.com/sfc-gh-ptabor) in [bazelbuild/bazel-gazelle#1582 - \[README.rst] Mention kotlin PoC by [@kolloch](https://togithub.com/kolloch) in [bazelbuild/bazel-gazelle#1590 - Fix and let `# gazelle:follow` accept a glob by [@shahms](https://togithub.com/shahms) in [bazelbuild/bazel-gazelle#1596 - Add support for isolated `go_deps` usages by [@fmeum](https://togithub.com/fmeum) in [bazelbuild/bazel-gazelle#1584 - feat(bzlmod): support archive_override in go_deps by [@tyler-french](https://togithub.com/tyler-french) in [bazelbuild/bazel-gazelle#1559 - fix: avoid updating `WORKSPACE` file when running `update-repos` when bzlmod is enabled by [@cgrindel](https://togithub.com/cgrindel) in [bazelbuild/bazel-gazelle#1589 - Make `go_deps.from_file` compatible with Go 1.21 by [@fmeum](https://togithub.com/fmeum) in [bazelbuild/bazel-gazelle#1605 - go_repository: fix missing default GOPROXY by [@sluongng](https://togithub.com/sluongng) in [bazelbuild/bazel-gazelle#1602 - fix: patch support for dir named workspace by [@michaellzc](https://togithub.com/michaellzc) in [bazelbuild/bazel-gazelle#1606 - Revert "go_repository: fix missing default GOPROXY ([#1602](https://togithub.com/bazelbuild/bazel-gazelle/issues/1602))" by [@sluongng](https://togithub.com/sluongng) in [bazelbuild/bazel-gazelle#1609 - Upgrade `golang.org/x/mod` Vendor to Support Go 1.21 by [@alan910127](https://togithub.com/alan910127) in [bazelbuild/bazel-gazelle#1611 - fix: go_repository: never shadow a module with a compatibility mapping for major versions. by [@reltuk](https://togithub.com/reltuk) in [bazelbuild/bazel-gazelle#1608 - bug fix: don't generate invalid go_binary rules for empty main packages by [@andyscott](https://togithub.com/andyscott) in [bazelbuild/bazel-gazelle#1618 - Fix wrong Kotlin Support link in README. by [@duckladydinh](https://togithub.com/duckladydinh) in [bazelbuild/bazel-gazelle#1619 - bzlmod: Verify that the lockfile is platform-independent by [@fmeum](https://togithub.com/fmeum) in [bazelbuild/bazel-gazelle#1617 - Add gazelle_rust under supported languages by [@Calsign](https://togithub.com/Calsign) in [bazelbuild/bazel-gazelle#1620 - replace golang.org/x/tools with golang.org/x/tools/go/vcs@v0.1.0-deprecated by [@malt3](https://togithub.com/malt3) in [bazelbuild/bazel-gazelle#1603 - Implement Merger interface by [@Whoaa512](https://togithub.com/Whoaa512) in [bazelbuild/bazel-gazelle#1569 - Improve Gazelle launcher's runfiles discovery on Windows by [@fmeum](https://togithub.com/fmeum) in [bazelbuild/bazel-gazelle#1604 - Add an entry for "github.com/googleapis/gax-go/v2" to default_gazelle_overrides.bzl by [@andrewmbenton](https://togithub.com/andrewmbenton) in [bazelbuild/bazel-gazelle#1623 - add a go_test directive to enable generating go_test targets per \_test.go file by [@shahms](https://togithub.com/shahms) in [bazelbuild/bazel-gazelle#1597 - Detect whether Gazelle itself is a Bazel module by [@fmeum](https://togithub.com/fmeum) in [bazelbuild/bazel-gazelle#1624 - prepare release 0.33 by [@tyler-french](https://togithub.com/tyler-french) in [bazelbuild/bazel-gazelle#1615 #### New Contributors - [@sfc-gh-ptabor](https://togithub.com/sfc-gh-ptabor) made their first contribution in [bazelbuild/bazel-gazelle#1582 - [@kolloch](https://togithub.com/kolloch) made their first contribution in [bazelbuild/bazel-gazelle#1590 - [@shahms](https://togithub.com/shahms) made their first contribution in [bazelbuild/bazel-gazelle#1596 - [@michaellzc](https://togithub.com/michaellzc) made their first contribution in [bazelbuild/bazel-gazelle#1606 - [@alan910127](https://togithub.com/alan910127) made their first contribution in [bazelbuild/bazel-gazelle#1611 - [@reltuk](https://togithub.com/reltuk) made their first contribution in [bazelbuild/bazel-gazelle#1608 - [@andyscott](https://togithub.com/andyscott) made their first contribution in [bazelbuild/bazel-gazelle#1618 - [@duckladydinh](https://togithub.com/duckladydinh) made their first contribution in [bazelbuild/bazel-gazelle#1619 - [@Calsign](https://togithub.com/Calsign) made their first contribution in [bazelbuild/bazel-gazelle#1620 - [@malt3](https://togithub.com/malt3) made their first contribution in [bazelbuild/bazel-gazelle#1603 - [@andrewmbenton](https://togithub.com/andrewmbenton) made their first contribution in [bazelbuild/bazel-gazelle#1623 **Full Changelog**: bazelbuild/bazel-gazelle@v0.32.0...v0.33.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/kreempuff/rules_unreal_engine).

[![Mend Renovate logo banner](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [bazel_gazelle](https://togithub.com/bazelbuild/bazel-gazelle) | http_archive | minor | `v0.32.0` -> `v0.34.0` | --- ### Release Notes <details> <summary>bazelbuild/bazel-gazelle (bazel_gazelle)</summary> ### [`v0.34.0`](https://togithub.com/bazelbuild/bazel-gazelle/releases/tag/v0.34.0) [Compare Source](https://togithub.com/bazelbuild/bazel-gazelle/compare/v0.33.0...v0.34.0) #### What's Changed - update readme for v0.33.0 by [@tyler-french](https://togithub.com/tyler-french) in [bazelbuild/bazel-gazelle#1627 - Remove golang.org/x/crypto dep by [@fmeum](https://togithub.com/fmeum) in [bazelbuild/bazel-gazelle#1631 - Fix map_kind with empty rules by [@lbcjbb](https://togithub.com/lbcjbb) in [bazelbuild/bazel-gazelle#1441 - fix: add missing bzl_library declaration and dep by [@cgrindel](https://togithub.com/cgrindel) in [bazelbuild/bazel-gazelle#1633 - chore: add bzl_test to ensure that bzl_library declarations exist by [@cgrindel](https://togithub.com/cgrindel) in [bazelbuild/bazel-gazelle#1634 - Set runfiles environment variables for Gazelle by [@fmeum](https://togithub.com/fmeum) in [bazelbuild/bazel-gazelle#1632 - address comments from [#1597](https://togithub.com/bazelbuild/bazel-gazelle/issues/1597) by [@shahms](https://togithub.com/shahms) in [bazelbuild/bazel-gazelle#1628 - Fix kinds and stmt by [@birunts](https://togithub.com/birunts) in [bazelbuild/bazel-gazelle#1613 - Export workspace file in go_repository_config.bzl by [@mortenmj](https://togithub.com/mortenmj) in [bazelbuild/bazel-gazelle#1641 - Add github.com/google/gnostic-models to default_gazelle_overrides.bzl by [@mortenmj](https://togithub.com/mortenmj) in [bazelbuild/bazel-gazelle#1645 - Support parsing labels that begin '@@' by [@mark-thm](https://togithub.com/mark-thm) in [bazelbuild/bazel-gazelle#1651 - Fix path for google/gnostic-models by [@mortenmj](https://togithub.com/mortenmj) in [bazelbuild/bazel-gazelle#1652 - fix(bzlmod): allow passing build_extra_args in gazelle_override by [@casuallyhostile](https://togithub.com/casuallyhostile) in [bazelbuild/bazel-gazelle#1648 - prepare release 0.34.0 by [@tyler-french](https://togithub.com/tyler-french) in [bazelbuild/bazel-gazelle#1656 #### New Contributors - [@casuallyhostile](https://togithub.com/casuallyhostile) made their first contribution in [bazelbuild/bazel-gazelle#1648 **Full Changelog**: bazelbuild/bazel-gazelle@v0.33.0...v0.34.0 ### [`v0.33.0`](https://togithub.com/bazelbuild/bazel-gazelle/releases/tag/v0.33.0) [Compare Source](https://togithub.com/bazelbuild/bazel-gazelle/compare/v0.32.0...v0.33.0) #### What's Changed - Generate BUILD files for grpc-gateway by default by [@seh](https://togithub.com/seh) in [bazelbuild/bazel-gazelle#1578 - Remove temporary workaround after rules_go 0.41.0 release by [@fmeum](https://togithub.com/fmeum) in [bazelbuild/bazel-gazelle#1577 - bzlmod: Use first host-compatible SDK to bootstrap Gazelle by [@fmeum](https://togithub.com/fmeum) in [bazelbuild/bazel-gazelle#1581 - Update: golang.org/x/exp & golang.org/x/oauth2 deps. by [@sfc-gh-ptabor](https://togithub.com/sfc-gh-ptabor) in [bazelbuild/bazel-gazelle#1582 - \[README.rst] Mention kotlin PoC by [@kolloch](https://togithub.com/kolloch) in [bazelbuild/bazel-gazelle#1590 - Fix and let `# gazelle:follow` accept a glob by [@shahms](https://togithub.com/shahms) in [bazelbuild/bazel-gazelle#1596 - Add support for isolated `go_deps` usages by [@fmeum](https://togithub.com/fmeum) in [bazelbuild/bazel-gazelle#1584 - feat(bzlmod): support archive_override in go_deps by [@tyler-french](https://togithub.com/tyler-french) in [bazelbuild/bazel-gazelle#1559 - fix: avoid updating `WORKSPACE` file when running `update-repos` when bzlmod is enabled by [@cgrindel](https://togithub.com/cgrindel) in [bazelbuild/bazel-gazelle#1589 - Make `go_deps.from_file` compatible with Go 1.21 by [@fmeum](https://togithub.com/fmeum) in [bazelbuild/bazel-gazelle#1605 - go_repository: fix missing default GOPROXY by [@sluongng](https://togithub.com/sluongng) in [bazelbuild/bazel-gazelle#1602 - fix: patch support for dir named workspace by [@michaellzc](https://togithub.com/michaellzc) in [bazelbuild/bazel-gazelle#1606 - Revert "go_repository: fix missing default GOPROXY ([#1602](https://togithub.com/bazelbuild/bazel-gazelle/issues/1602))" by [@sluongng](https://togithub.com/sluongng) in [bazelbuild/bazel-gazelle#1609 - Upgrade `golang.org/x/mod` Vendor to Support Go 1.21 by [@alan910127](https://togithub.com/alan910127) in [bazelbuild/bazel-gazelle#1611 - fix: go_repository: never shadow a module with a compatibility mapping for major versions. by [@reltuk](https://togithub.com/reltuk) in [bazelbuild/bazel-gazelle#1608 - bug fix: don't generate invalid go_binary rules for empty main packages by [@andyscott](https://togithub.com/andyscott) in [bazelbuild/bazel-gazelle#1618 - Fix wrong Kotlin Support link in README. by [@duckladydinh](https://togithub.com/duckladydinh) in [bazelbuild/bazel-gazelle#1619 - bzlmod: Verify that the lockfile is platform-independent by [@fmeum](https://togithub.com/fmeum) in [bazelbuild/bazel-gazelle#1617 - Add gazelle_rust under supported languages by [@Calsign](https://togithub.com/Calsign) in [bazelbuild/bazel-gazelle#1620 - replace golang.org/x/tools with golang.org/x/tools/go/vcs@v0.1.0-deprecated by [@malt3](https://togithub.com/malt3) in [bazelbuild/bazel-gazelle#1603 - Implement Merger interface by [@Whoaa512](https://togithub.com/Whoaa512) in [bazelbuild/bazel-gazelle#1569 - Improve Gazelle launcher's runfiles discovery on Windows by [@fmeum](https://togithub.com/fmeum) in [bazelbuild/bazel-gazelle#1604 - Add an entry for "github.com/googleapis/gax-go/v2" to default_gazelle_overrides.bzl by [@andrewmbenton](https://togithub.com/andrewmbenton) in [bazelbuild/bazel-gazelle#1623 - add a go_test directive to enable generating go_test targets per \_test.go file by [@shahms](https://togithub.com/shahms) in [bazelbuild/bazel-gazelle#1597 - Detect whether Gazelle itself is a Bazel module by [@fmeum](https://togithub.com/fmeum) in [bazelbuild/bazel-gazelle#1624 - prepare release 0.33 by [@tyler-french](https://togithub.com/tyler-french) in [bazelbuild/bazel-gazelle#1615 #### New Contributors - [@sfc-gh-ptabor](https://togithub.com/sfc-gh-ptabor) made their first contribution in [bazelbuild/bazel-gazelle#1582 - [@kolloch](https://togithub.com/kolloch) made their first contribution in [bazelbuild/bazel-gazelle#1590 - [@shahms](https://togithub.com/shahms) made their first contribution in [bazelbuild/bazel-gazelle#1596 - [@michaellzc](https://togithub.com/michaellzc) made their first contribution in [bazelbuild/bazel-gazelle#1606 - [@alan910127](https://togithub.com/alan910127) made their first contribution in [bazelbuild/bazel-gazelle#1611 - [@reltuk](https://togithub.com/reltuk) made their first contribution in [bazelbuild/bazel-gazelle#1608 - [@andyscott](https://togithub.com/andyscott) made their first contribution in [bazelbuild/bazel-gazelle#1618 - [@duckladydinh](https://togithub.com/duckladydinh) made their first contribution in [bazelbuild/bazel-gazelle#1619 - [@Calsign](https://togithub.com/Calsign) made their first contribution in [bazelbuild/bazel-gazelle#1620 - [@malt3](https://togithub.com/malt3) made their first contribution in [bazelbuild/bazel-gazelle#1603 - [@andrewmbenton](https://togithub.com/andrewmbenton) made their first contribution in [bazelbuild/bazel-gazelle#1623 **Full Changelog**: bazelbuild/bazel-gazelle@v0.32.0...v0.33.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "before 4am on Monday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/aspect-build/rules_py).  Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

…t.go file (bazelbuild#1597) * add a go_test directive to enable generating go_test targets per _test.go file * address comments * add new tests for updating to per-file mode --------- Co-authored-by: Fabian Meumertzheim <fabian@meumertzhe.im>

shahms and others added 3 commits July 31, 2023 13:25

add a go_test directive to enable generating go_test targets per _tes…

9ab60bc

…t.go file

Merge branch 'master' into per-file-go_test

fe7b983

Merge branch 'master' into per-file-go_test

518c99d

shahms mentioned this pull request Aug 3, 2023

Enable generating go_test targets per _test.go file in a directory #1594

Closed

fmeum reviewed Aug 4, 2023

View reviewed changes

language/go/generate.go Outdated Show resolved Hide resolved

language/go/package.go Outdated Show resolved Hide resolved

language/go/testdata/tests_per_file/BUILD.want Outdated Show resolved Hide resolved

shahms and others added 3 commits August 4, 2023 13:56

Merge branch 'master' into per-file-go_test

68fcc75

address comments

3f4cea8

Merge branch 'master' into per-file-go_test

fbe9226

shahms added 2 commits August 25, 2023 09:08

Merge branch 'master' into per-file-go_test

8e98986

add new tests for updating to per-file mode

cf24f22

fmeum approved these changes Aug 26, 2023

View reviewed changes

Merge branch 'master' into per-file-go_test

6448481

fmeum added 2 commits September 1, 2023 10:33

Merge branch 'master' into per-file-go_test

f583aa5

Merge branch 'master' into per-file-go_test

25da6b2

fmeum enabled auto-merge (squash) September 6, 2023 00:18

fmeum mentioned this pull request Sep 6, 2023

prepare release 0.33 #1615

Merged

fmeum merged commit 8977484 into bazelbuild:master Sep 6, 2023
9 of 10 checks passed

tyler-french reviewed Sep 6, 2023

View reviewed changes

shahms deleted the per-file-go_test branch September 6, 2023 15:12

shahms added a commit to shahms/bazel-gazelle that referenced this pull request Sep 6, 2023

address comments from bazelbuild#1597

e476eeb

shahms mentioned this pull request Sep 6, 2023

address comments from #1597 #1628

Merged

fmeum pushed a commit to shahms/bazel-gazelle that referenced this pull request Sep 15, 2023

address comments from bazelbuild#1597

880d4f8

fmeum pushed a commit that referenced this pull request Sep 15, 2023

address comments from #1597 (#1628)

b2a81af

sluongng mentioned this pull request Jan 17, 2024

Flip GO_TEST_WRAP_TESTV default bazelbuild/rules_go#3835

Open

jeromep-stripe pushed a commit to jeromep-stripe/bazel-gazelle that referenced this pull request Mar 22, 2024

address comments from bazelbuild#1597 (bazelbuild#1628)

1b69631

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add a go_test directive to enable generating go_test targets per _test.go file #1597

add a go_test directive to enable generating go_test targets per _test.go file #1597

shahms commented Aug 2, 2023

shahms commented Aug 11, 2023

fmeum commented Aug 13, 2023

shahms commented Aug 25, 2023

fmeum left a comment

fmeum commented Aug 26, 2023

shahms commented Aug 28, 2023

tyler-french commented Aug 29, 2023 •

edited

shahms commented Aug 30, 2023

fmeum commented Aug 30, 2023

sluongng commented Aug 31, 2023

hawkingrei commented Sep 6, 2023

tyler-french Aug 28, 2023

tyler-french Aug 28, 2023

tyler-french Aug 28, 2023

tyler-french commented Sep 6, 2023

fmeum commented Sep 6, 2023

shahms commented Sep 6, 2023

add a go_test directive to enable generating go_test targets per _test.go file #1597

add a go_test directive to enable generating go_test targets per _test.go file #1597

Conversation

shahms commented Aug 2, 2023

shahms commented Aug 11, 2023

fmeum commented Aug 13, 2023

shahms commented Aug 25, 2023

fmeum left a comment

Choose a reason for hiding this comment

fmeum commented Aug 26, 2023

shahms commented Aug 28, 2023

tyler-french commented Aug 29, 2023 • edited

shahms commented Aug 30, 2023

fmeum commented Aug 30, 2023

sluongng commented Aug 31, 2023

hawkingrei commented Sep 6, 2023

tyler-french Aug 28, 2023

Choose a reason for hiding this comment

tyler-french Aug 28, 2023

Choose a reason for hiding this comment

tyler-french Aug 28, 2023

Choose a reason for hiding this comment

tyler-french commented Sep 6, 2023

fmeum commented Sep 6, 2023

shahms commented Sep 6, 2023

tyler-french commented Aug 29, 2023 •

edited