Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply map_kind to existing rules as well as new ones #1425

Merged
merged 7 commits into from
Feb 10, 2023
Merged

Apply map_kind to existing rules as well as new ones #1425

merged 7 commits into from
Feb 10, 2023

Commits on Feb 7, 2023

  1. Add tests for a bunch of map_kind edge cases

    @illicitonion
    illicitonion committed Feb 7, 2023
    Configuration menu
    Copy the full SHA
    594e394 View commit details
    Browse the repository at this point in the history

  2. Apply map_kind to existing rules as well as new ones 

    Fixes bazelbuild#1391
    @illicitonion
    illicitonion committed Feb 7, 2023
    Configuration menu
    Copy the full SHA
    0b1f447 View commit details
    Browse the repository at this point in the history

  3. Handle transitive map_kind directives 

    Before, if you mapped a -> b and b -> c, a would not be mapped to c.

This fixes that situation, and introduces an error state of a loop is
detected. The error is only raised if a loop is actually encountered by
some rule.
    @illicitonion
    illicitonion committed Feb 7, 2023
    Configuration menu
    Copy the full SHA
    8dee9e5 View commit details
    Browse the repository at this point in the history

  4. Simplify function

    @illicitonion
    illicitonion committed Feb 7, 2023
    Configuration menu
    Copy the full SHA
    49697e5 View commit details
    Browse the repository at this point in the history

  5. Update cmd/gazelle/fix-update.go 

    Co-authored-by: Son Luong Ngoc <sluongng@gmail.com>
    @illicitonion @sluongng
    illicitonion and sluongng committed Feb 7, 2023
    Configuration menu
    Copy the full SHA
    94ee030 View commit details
    Browse the repository at this point in the history

  6. Update cmd/gazelle/fix-update.go 

    Co-authored-by: Son Luong Ngoc <sluongng@gmail.com>
    @illicitonion @sluongng
    illicitonion and sluongng committed Feb 7, 2023
    Configuration menu
    Copy the full SHA
    8241316 View commit details
    Browse the repository at this point in the history

Commits on Feb 10, 2023

  1. Tidy up error message to be less repetative

    @illicitonion
    illicitonion committed Feb 10, 2023
    Configuration menu
    Copy the full SHA
    c8c2e77 View commit details
    Browse the repository at this point in the history