Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bzlmod: Remove deprecated override attributes on go_deps.module #1548

Merged
merged 1 commit into from
May 30, 2023

Conversation

fmeum
Copy link
Collaborator

@fmeum fmeum commented May 27, 2023

No description provided.

@fmeum fmeum requested a review from linzhp May 27, 2023 19:53
@fmeum
Copy link
Collaborator Author

fmeum commented May 27, 2023

@seh Could you take a look?

Copy link
Contributor

@seh seh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's good to see the evolution progressing as promised.

internal/bzlmod/go_deps.bzl Show resolved Hide resolved
@fmeum
Copy link
Collaborator Author

fmeum commented May 28, 2023

@linzhp Could you test at Uber?

Copy link
Contributor

@tyler-french tyler-french left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested at Uber (cc @linzhp)

@fmeum fmeum merged commit 56b3f78 into master May 30, 2023
10 checks passed
@fmeum fmeum deleted the remove-override-attrs branch May 30, 2023 15:47
renovate bot added a commit to kreempuff/rules_unreal_engine that referenced this pull request Jun 13, 2023
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [bazel_gazelle](https://togithub.com/bazelbuild/bazel-gazelle) |
http_archive | patch | `v0.31.0` -> `v0.31.1` |

---

### ⚠ Dependency Lookup Warnings ⚠

Warnings were logged while processing this repo. Please check the
Dependency Dashboard for more information.

---

### Release Notes

<details>
<summary>bazelbuild/bazel-gazelle</summary>

###
[`v0.31.1`](https://togithub.com/bazelbuild/bazel-gazelle/releases/tag/v0.31.1)

[Compare
Source](https://togithub.com/bazelbuild/bazel-gazelle/compare/v0.31.0...v0.31.1)

#### What's Changed

- point sync.Once in walkConfig by
[@&#8203;jmhodges](https://togithub.com/jmhodges) in
[bazelbuild/bazel-gazelle#1532
- add copylock vet to nogo by
[@&#8203;jmhodges](https://togithub.com/jmhodges) in
[bazelbuild/bazel-gazelle#1534
- bzlmod: Remove deprecated override attributes on `go_deps.module` by
[@&#8203;fmeum](https://togithub.com/fmeum) in
[bazelbuild/bazel-gazelle#1548
- Add default directives for github.com/envoyproxy/protoc-gen-validate
by [@&#8203;mortenmj](https://togithub.com/mortenmj) in
[bazelbuild/bazel-gazelle#1553
- cmd/gazelle: do not use the epoch as timestamp in diff output by
[@&#8203;siddharthab](https://togithub.com/siddharthab) in
[bazelbuild/bazel-gazelle#1552
- fileinfo: fix not detecting 'unix' files to be OS specific by
[@&#8203;sluongng](https://togithub.com/sluongng) in
[bazelbuild/bazel-gazelle#1554
- language/go: Emit apparent repo name of rules_go in select keys by
[@&#8203;fmeum](https://togithub.com/fmeum) in
[bazelbuild/bazel-gazelle#1555
- Let `bazel_dep`s replace Go deps by
[@&#8203;fmeum](https://togithub.com/fmeum) in
[bazelbuild/bazel-gazelle#1526

#### New Contributors

- [@&#8203;mortenmj](https://togithub.com/mortenmj) made their first
contribution in
[bazelbuild/bazel-gazelle#1553

**Full Changelog**:
bazelbuild/bazel-gazelle@v0.31.0...v0.31.1

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://app.renovatebot.com/dashboard#github/kreempuff/rules_unreal_engine).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS4xMTAuMCIsInVwZGF0ZWRJblZlciI6IjM1LjExMC4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->
renovate bot added a commit to cgrindel/rules_swift_package_manager that referenced this pull request Jun 13, 2023
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [bazel_gazelle](https://togithub.com/bazelbuild/bazel-gazelle) |
http_archive | patch | `v0.31.0` -> `v0.31.1` |

---

### Release Notes

<details>
<summary>bazelbuild/bazel-gazelle</summary>

###
[`v0.31.1`](https://togithub.com/bazelbuild/bazel-gazelle/releases/tag/v0.31.1)

[Compare
Source](https://togithub.com/bazelbuild/bazel-gazelle/compare/v0.31.0...v0.31.1)

#### What's Changed

- point sync.Once in walkConfig by
[@&#8203;jmhodges](https://togithub.com/jmhodges) in
[bazelbuild/bazel-gazelle#1532
- add copylock vet to nogo by
[@&#8203;jmhodges](https://togithub.com/jmhodges) in
[bazelbuild/bazel-gazelle#1534
- bzlmod: Remove deprecated override attributes on `go_deps.module` by
[@&#8203;fmeum](https://togithub.com/fmeum) in
[bazelbuild/bazel-gazelle#1548
- Add default directives for github.com/envoyproxy/protoc-gen-validate
by [@&#8203;mortenmj](https://togithub.com/mortenmj) in
[bazelbuild/bazel-gazelle#1553
- cmd/gazelle: do not use the epoch as timestamp in diff output by
[@&#8203;siddharthab](https://togithub.com/siddharthab) in
[bazelbuild/bazel-gazelle#1552
- fileinfo: fix not detecting 'unix' files to be OS specific by
[@&#8203;sluongng](https://togithub.com/sluongng) in
[bazelbuild/bazel-gazelle#1554
- language/go: Emit apparent repo name of rules_go in select keys by
[@&#8203;fmeum](https://togithub.com/fmeum) in
[bazelbuild/bazel-gazelle#1555
- Let `bazel_dep`s replace Go deps by
[@&#8203;fmeum](https://togithub.com/fmeum) in
[bazelbuild/bazel-gazelle#1526

#### New Contributors

- [@&#8203;mortenmj](https://togithub.com/mortenmj) made their first
contribution in
[bazelbuild/bazel-gazelle#1553

**Full Changelog**:
bazelbuild/bazel-gazelle@v0.31.0...v0.31.1

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR is behind base branch, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://app.renovatebot.com/dashboard#github/cgrindel/rules_swift_package_manager).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS4xMTAuMCIsInVwZGF0ZWRJblZlciI6IjM1LjExMC4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
renovate bot added a commit to cgrindel/bazel-starlib that referenced this pull request Jun 13, 2023
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [bazel_gazelle](https://togithub.com/bazelbuild/bazel-gazelle) |
http_archive | patch | `v0.31.0` -> `v0.31.1` |

---

### Release Notes

<details>
<summary>bazelbuild/bazel-gazelle</summary>

###
[`v0.31.1`](https://togithub.com/bazelbuild/bazel-gazelle/releases/tag/v0.31.1)

[Compare
Source](https://togithub.com/bazelbuild/bazel-gazelle/compare/v0.31.0...v0.31.1)

#### What's Changed

- point sync.Once in walkConfig by
[@&#8203;jmhodges](https://togithub.com/jmhodges) in
[bazelbuild/bazel-gazelle#1532
- add copylock vet to nogo by
[@&#8203;jmhodges](https://togithub.com/jmhodges) in
[bazelbuild/bazel-gazelle#1534
- bzlmod: Remove deprecated override attributes on `go_deps.module` by
[@&#8203;fmeum](https://togithub.com/fmeum) in
[bazelbuild/bazel-gazelle#1548
- Add default directives for github.com/envoyproxy/protoc-gen-validate
by [@&#8203;mortenmj](https://togithub.com/mortenmj) in
[bazelbuild/bazel-gazelle#1553
- cmd/gazelle: do not use the epoch as timestamp in diff output by
[@&#8203;siddharthab](https://togithub.com/siddharthab) in
[bazelbuild/bazel-gazelle#1552
- fileinfo: fix not detecting 'unix' files to be OS specific by
[@&#8203;sluongng](https://togithub.com/sluongng) in
[bazelbuild/bazel-gazelle#1554
- language/go: Emit apparent repo name of rules_go in select keys by
[@&#8203;fmeum](https://togithub.com/fmeum) in
[bazelbuild/bazel-gazelle#1555
- Let `bazel_dep`s replace Go deps by
[@&#8203;fmeum](https://togithub.com/fmeum) in
[bazelbuild/bazel-gazelle#1526

#### New Contributors

- [@&#8203;mortenmj](https://togithub.com/mortenmj) made their first
contribution in
[bazelbuild/bazel-gazelle#1553

**Full Changelog**:
bazelbuild/bazel-gazelle@v0.31.0...v0.31.1

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR is behind base branch, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://app.renovatebot.com/dashboard#github/cgrindel/bazel-starlib).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS4xMTAuMCIsInVwZGF0ZWRJblZlciI6IjM1LjExMC4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants