Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make isolated extensions usable for Go tools #1678

Merged
merged 1 commit into from
Dec 4, 2023
Merged

Make isolated extensions usable for Go tools #1678

merged 1 commit into from
Dec 4, 2023

Conversation

fmeum
Copy link
Collaborator

@fmeum fmeum commented Dec 2, 2023

Prevent linker errors by sharing go_proto_library dependencies across isolated dependency closures, which allows the standard tools.go approach to be used to manage Go tools with go_deps with fully separate version resolution.

Fixes bazelbuild/rules_go#3646

@fmeum fmeum force-pushed the tools branch 2 times, most recently from dd922b6 to 4b43228 Compare December 2, 2023 15:59
@fmeum fmeum changed the title Test usage of isolated extensions for Go tools Make isolated extensions usable for Go tools Dec 2, 2023
@fmeum fmeum marked this pull request as ready for review December 2, 2023 16:22
@fmeum fmeum merged commit c677d12 into master Dec 4, 2023
10 checks passed
@fmeum fmeum deleted the tools branch December 4, 2023 08:00
renovate bot added a commit to kreempuff/rules_unreal_engine that referenced this pull request Dec 21, 2023
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [bazel_gazelle](https://togithub.com/bazelbuild/bazel-gazelle) |
http_archive | minor | `v0.34.0` -> `v0.35.0` |

---

> [!WARNING]
> Some dependencies could not be looked up. Check the Dependency
Dashboard for more information.

---

### Release Notes

<details>
<summary>bazelbuild/bazel-gazelle (bazel_gazelle)</summary>

###
[`v0.35.0`](https://togithub.com/bazelbuild/bazel-gazelle/releases/tag/v0.35.0)

[Compare
Source](https://togithub.com/bazelbuild/bazel-gazelle/compare/v0.34.0...v0.35.0)

#### What's Changed

- Don't run on centos7 in BCR presubmit and add maintainers by
[@&#8203;fmeum](https://togithub.com/fmeum) in
[bazelbuild/bazel-gazelle#1663
- update readme for v0.34.0 by
[@&#8203;tyler-french](https://togithub.com/tyler-french) in
[bazelbuild/bazel-gazelle#1662
- nit: doc `gazelle_generation_test` use of `arguments.txt` by
[@&#8203;vpanta](https://togithub.com/vpanta) in
[bazelbuild/bazel-gazelle#1660
- feat(bzlmod): allow patches in `archive_override`s by
[@&#8203;tyler-french](https://togithub.com/tyler-french) in
[bazelbuild/bazel-gazelle#1665
- fix(bzlmod): fail on unused overrides by
[@&#8203;tyler-french](https://togithub.com/tyler-french) in
[bazelbuild/bazel-gazelle#1669
- Annotate more globs with `allow_empty = True` by
[@&#8203;fmeum](https://togithub.com/fmeum) in
[bazelbuild/bazel-gazelle#1674
- Generate BUILD files for grpc compiler by
[@&#8203;mering](https://togithub.com/mering) in
[bazelbuild/bazel-gazelle#1672
- Disable lockfile check for BCR test module by
[@&#8203;fmeum](https://togithub.com/fmeum) in
[bazelbuild/bazel-gazelle#1673
- Make isolated extensions usable for Go tools by
[@&#8203;fmeum](https://togithub.com/fmeum) in
[bazelbuild/bazel-gazelle#1678
- bzlmod: support go.mod replace directives with a version qualifier on
the left by [@&#8203;andyscott](https://togithub.com/andyscott) in
[bazelbuild/bazel-gazelle#1679
- fix CI by running both WORKSPACE and Bzlmod on select packages by
[@&#8203;tyler-french](https://togithub.com/tyler-french) in
[bazelbuild/bazel-gazelle#1690
- disable lockfile by default by
[@&#8203;tyler-french](https://togithub.com/tyler-french) in
[bazelbuild/bazel-gazelle#1692
- feat(resolve): optimize applying overrides to be efficient by
[@&#8203;tyler-french](https://togithub.com/tyler-french) in
[bazelbuild/bazel-gazelle#1687
- feat(fix-update): allow user to profile commands with `pprof` by
[@&#8203;tyler-french](https://togithub.com/tyler-french) in
[bazelbuild/bazel-gazelle#1685
- Fix partial execution with mapped kinds by
[@&#8203;HALtheWise](https://togithub.com/HALtheWise) in
[bazelbuild/bazel-gazelle#1680
- prepare release 0.35.0 by
[@&#8203;tyler-french](https://togithub.com/tyler-french) in
[bazelbuild/bazel-gazelle#1693

#### New Contributors

- [@&#8203;mering](https://togithub.com/mering) made their first
contribution in
[bazelbuild/bazel-gazelle#1672

**Full Changelog**:
bazelbuild/bazel-gazelle@v0.34.0...v0.35.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/kreempuff/rules_unreal_engine).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xMDMuMSIsInVwZGF0ZWRJblZlciI6IjM3LjEwMy4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->
cgrindel-self-hosted-renovate bot added a commit to cgrindel/bazel-starlib that referenced this pull request Dec 21, 2023
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [bazel_gazelle](https://togithub.com/bazelbuild/bazel-gazelle) |
http_archive | minor | `v0.34.0` -> `v0.35.0` |

---

### Release Notes

<details>
<summary>bazelbuild/bazel-gazelle (bazel_gazelle)</summary>

###
[`v0.35.0`](https://togithub.com/bazelbuild/bazel-gazelle/releases/tag/v0.35.0)

[Compare
Source](https://togithub.com/bazelbuild/bazel-gazelle/compare/v0.34.0...v0.35.0)

#### What's Changed

- Don't run on centos7 in BCR presubmit and add maintainers by
[@&#8203;fmeum](https://togithub.com/fmeum) in
[bazelbuild/bazel-gazelle#1663
- update readme for v0.34.0 by
[@&#8203;tyler-french](https://togithub.com/tyler-french) in
[bazelbuild/bazel-gazelle#1662
- nit: doc `gazelle_generation_test` use of `arguments.txt` by
[@&#8203;vpanta](https://togithub.com/vpanta) in
[bazelbuild/bazel-gazelle#1660
- feat(bzlmod): allow patches in `archive_override`s by
[@&#8203;tyler-french](https://togithub.com/tyler-french) in
[bazelbuild/bazel-gazelle#1665
- fix(bzlmod): fail on unused overrides by
[@&#8203;tyler-french](https://togithub.com/tyler-french) in
[bazelbuild/bazel-gazelle#1669
- Annotate more globs with `allow_empty = True` by
[@&#8203;fmeum](https://togithub.com/fmeum) in
[bazelbuild/bazel-gazelle#1674
- Generate BUILD files for grpc compiler by
[@&#8203;mering](https://togithub.com/mering) in
[bazelbuild/bazel-gazelle#1672
- Disable lockfile check for BCR test module by
[@&#8203;fmeum](https://togithub.com/fmeum) in
[bazelbuild/bazel-gazelle#1673
- Make isolated extensions usable for Go tools by
[@&#8203;fmeum](https://togithub.com/fmeum) in
[bazelbuild/bazel-gazelle#1678
- bzlmod: support go.mod replace directives with a version qualifier on
the left by [@&#8203;andyscott](https://togithub.com/andyscott) in
[bazelbuild/bazel-gazelle#1679
- fix CI by running both WORKSPACE and Bzlmod on select packages by
[@&#8203;tyler-french](https://togithub.com/tyler-french) in
[bazelbuild/bazel-gazelle#1690
- disable lockfile by default by
[@&#8203;tyler-french](https://togithub.com/tyler-french) in
[bazelbuild/bazel-gazelle#1692
- feat(resolve): optimize applying overrides to be efficient by
[@&#8203;tyler-french](https://togithub.com/tyler-french) in
[bazelbuild/bazel-gazelle#1687
- feat(fix-update): allow user to profile commands with `pprof` by
[@&#8203;tyler-french](https://togithub.com/tyler-french) in
[bazelbuild/bazel-gazelle#1685
- Fix partial execution with mapped kinds by
[@&#8203;HALtheWise](https://togithub.com/HALtheWise) in
[bazelbuild/bazel-gazelle#1680
- prepare release 0.35.0 by
[@&#8203;tyler-french](https://togithub.com/tyler-french) in
[bazelbuild/bazel-gazelle#1693

#### New Contributors

- [@&#8203;mering](https://togithub.com/mering) made their first
contribution in
[bazelbuild/bazel-gazelle#1672

**Full Changelog**:
bazelbuild/bazel-gazelle@v0.34.0...v0.35.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR is behind base branch, or you tick the
rebase/retry checkbox.

👻 **Immortal**: This PR will be recreated if closed unmerged. Get
[config help](https://togithub.com/renovatebot/renovate/discussions) if
that's undesired.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Renovate
Bot](https://togithub.com/renovatebot/renovate).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi4xMDAuMCIsInVwZGF0ZWRJblZlciI6IjM2LjEwMC4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->

Co-authored-by: Self-hosted Renovate Bot <361546+cgrindel-self-hosted-renovate[bot]@users.noreply.github.enterprise.com>
cgrindel-self-hosted-renovate bot added a commit to cgrindel/rules_swift_package_manager that referenced this pull request Dec 22, 2023
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [bazel_gazelle](https://togithub.com/bazelbuild/bazel-gazelle) |
http_archive | minor | `v0.34.0` -> `v0.35.0` |

---

### Release Notes

<details>
<summary>bazelbuild/bazel-gazelle (bazel_gazelle)</summary>

###
[`v0.35.0`](https://togithub.com/bazelbuild/bazel-gazelle/releases/tag/v0.35.0)

[Compare
Source](https://togithub.com/bazelbuild/bazel-gazelle/compare/v0.34.0...v0.35.0)

#### What's Changed

- Don't run on centos7 in BCR presubmit and add maintainers by
[@&#8203;fmeum](https://togithub.com/fmeum) in
[bazelbuild/bazel-gazelle#1663
- update readme for v0.34.0 by
[@&#8203;tyler-french](https://togithub.com/tyler-french) in
[bazelbuild/bazel-gazelle#1662
- nit: doc `gazelle_generation_test` use of `arguments.txt` by
[@&#8203;vpanta](https://togithub.com/vpanta) in
[bazelbuild/bazel-gazelle#1660
- feat(bzlmod): allow patches in `archive_override`s by
[@&#8203;tyler-french](https://togithub.com/tyler-french) in
[bazelbuild/bazel-gazelle#1665
- fix(bzlmod): fail on unused overrides by
[@&#8203;tyler-french](https://togithub.com/tyler-french) in
[bazelbuild/bazel-gazelle#1669
- Annotate more globs with `allow_empty = True` by
[@&#8203;fmeum](https://togithub.com/fmeum) in
[bazelbuild/bazel-gazelle#1674
- Generate BUILD files for grpc compiler by
[@&#8203;mering](https://togithub.com/mering) in
[bazelbuild/bazel-gazelle#1672
- Disable lockfile check for BCR test module by
[@&#8203;fmeum](https://togithub.com/fmeum) in
[bazelbuild/bazel-gazelle#1673
- Make isolated extensions usable for Go tools by
[@&#8203;fmeum](https://togithub.com/fmeum) in
[bazelbuild/bazel-gazelle#1678
- bzlmod: support go.mod replace directives with a version qualifier on
the left by [@&#8203;andyscott](https://togithub.com/andyscott) in
[bazelbuild/bazel-gazelle#1679
- fix CI by running both WORKSPACE and Bzlmod on select packages by
[@&#8203;tyler-french](https://togithub.com/tyler-french) in
[bazelbuild/bazel-gazelle#1690
- disable lockfile by default by
[@&#8203;tyler-french](https://togithub.com/tyler-french) in
[bazelbuild/bazel-gazelle#1692
- feat(resolve): optimize applying overrides to be efficient by
[@&#8203;tyler-french](https://togithub.com/tyler-french) in
[bazelbuild/bazel-gazelle#1687
- feat(fix-update): allow user to profile commands with `pprof` by
[@&#8203;tyler-french](https://togithub.com/tyler-french) in
[bazelbuild/bazel-gazelle#1685
- Fix partial execution with mapped kinds by
[@&#8203;HALtheWise](https://togithub.com/HALtheWise) in
[bazelbuild/bazel-gazelle#1680
- prepare release 0.35.0 by
[@&#8203;tyler-french](https://togithub.com/tyler-french) in
[bazelbuild/bazel-gazelle#1693

#### New Contributors

- [@&#8203;mering](https://togithub.com/mering) made their first
contribution in
[bazelbuild/bazel-gazelle#1672

**Full Changelog**:
bazelbuild/bazel-gazelle@v0.34.0...v0.35.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR is behind base branch, or you tick the
rebase/retry checkbox.

👻 **Immortal**: This PR will be recreated if closed unmerged. Get
[config help](https://togithub.com/renovatebot/renovate/discussions) if
that's undesired.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Renovate
Bot](https://togithub.com/renovatebot/renovate).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi4xMDAuMCIsInVwZGF0ZWRJblZlciI6IjM2LjEwMC4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->

Co-authored-by: Self-hosted Renovate Bot <361546+cgrindel-self-hosted-renovate[bot]@users.noreply.github.enterprise.com>
alexeagle pushed a commit to aspect-build/rules_py that referenced this pull request Feb 2, 2024
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [bazel_gazelle](https://togithub.com/bazelbuild/bazel-gazelle) |
http_archive | minor | `v0.34.0` -> `v0.35.0` |

---

### Release Notes

<details>
<summary>bazelbuild/bazel-gazelle (bazel_gazelle)</summary>

###
[`v0.35.0`](https://togithub.com/bazelbuild/bazel-gazelle/releases/tag/v0.35.0)

[Compare
Source](https://togithub.com/bazelbuild/bazel-gazelle/compare/v0.34.0...v0.35.0)

#### What's Changed

- Don't run on centos7 in BCR presubmit and add maintainers by
[@&#8203;fmeum](https://togithub.com/fmeum) in
[bazelbuild/bazel-gazelle#1663
- update readme for v0.34.0 by
[@&#8203;tyler-french](https://togithub.com/tyler-french) in
[bazelbuild/bazel-gazelle#1662
- nit: doc `gazelle_generation_test` use of `arguments.txt` by
[@&#8203;vpanta](https://togithub.com/vpanta) in
[bazelbuild/bazel-gazelle#1660
- feat(bzlmod): allow patches in `archive_override`s by
[@&#8203;tyler-french](https://togithub.com/tyler-french) in
[bazelbuild/bazel-gazelle#1665
- fix(bzlmod): fail on unused overrides by
[@&#8203;tyler-french](https://togithub.com/tyler-french) in
[bazelbuild/bazel-gazelle#1669
- Annotate more globs with `allow_empty = True` by
[@&#8203;fmeum](https://togithub.com/fmeum) in
[bazelbuild/bazel-gazelle#1674
- Generate BUILD files for grpc compiler by
[@&#8203;mering](https://togithub.com/mering) in
[bazelbuild/bazel-gazelle#1672
- Disable lockfile check for BCR test module by
[@&#8203;fmeum](https://togithub.com/fmeum) in
[bazelbuild/bazel-gazelle#1673
- Make isolated extensions usable for Go tools by
[@&#8203;fmeum](https://togithub.com/fmeum) in
[bazelbuild/bazel-gazelle#1678
- bzlmod: support go.mod replace directives with a version qualifier on
the left by [@&#8203;andyscott](https://togithub.com/andyscott) in
[bazelbuild/bazel-gazelle#1679
- fix CI by running both WORKSPACE and Bzlmod on select packages by
[@&#8203;tyler-french](https://togithub.com/tyler-french) in
[bazelbuild/bazel-gazelle#1690
- disable lockfile by default by
[@&#8203;tyler-french](https://togithub.com/tyler-french) in
[bazelbuild/bazel-gazelle#1692
- feat(resolve): optimize applying overrides to be efficient by
[@&#8203;tyler-french](https://togithub.com/tyler-french) in
[bazelbuild/bazel-gazelle#1687
- feat(fix-update): allow user to profile commands with `pprof` by
[@&#8203;tyler-french](https://togithub.com/tyler-french) in
[bazelbuild/bazel-gazelle#1685
- Fix partial execution with mapped kinds by
[@&#8203;HALtheWise](https://togithub.com/HALtheWise) in
[bazelbuild/bazel-gazelle#1680
- prepare release 0.35.0 by
[@&#8203;tyler-french](https://togithub.com/tyler-french) in
[bazelbuild/bazel-gazelle#1693

#### New Contributors

- [@&#8203;mering](https://togithub.com/mering) made their first
contribution in
[bazelbuild/bazel-gazelle#1672

**Full Changelog**:
bazelbuild/bazel-gazelle@v0.34.0...v0.35.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "before 4am on Monday" (UTC),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR is behind base branch, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/aspect-build/rules_py).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xMjEuMCIsInVwZGF0ZWRJblZlciI6IjM3LjEyMS4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
jeromep-stripe pushed a commit to jeromep-stripe/bazel-gazelle that referenced this pull request Mar 22, 2024
Prevent linker errors by sharing go_proto_library dependencies across isolated dependency closures, which allows the standard tools.go approach to be used to manage Go tools with go_deps with fully separate version resolution.

Fixes bazelbuild/rules_go#3646
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bzlmod: offer "go install" like capabilities
2 participants