Skip to content

Commit

Permalink
Improve inspect_output_dirs_test bin_dir comparison (#267)
Browse files Browse the repository at this point in the history
This should fix some buildkite CI flows, ensuring success of
this test is no longer tied to the current compilation_mode.
It also improves the error message of the offending evaluation.
  • Loading branch information
c-parsons committed Aug 20, 2020
1 parent dc080e9 commit 68acaa5
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions tests/unittest_tests.bzl
Expand Up @@ -196,7 +196,7 @@ def _inspect_output_dirs_test(ctx):
asserts.false(
env,
bin_path == ctx.bin_dir.path,
"bin dir path expected to differ between test and target_under_test.",
"test bin dir (%s) expected to differ with target_under_test bin dir (%s)." % (bin_path, ctx.bin_dir.path),
)
asserts.equals(env, bin_path, target_under_test[_OutputDirInfo].bin_path)
return analysistest.end(env)
Expand All @@ -217,7 +217,7 @@ inspect_output_dirs_test = analysistest.make(
# The output directories differ between the test and target under test when
# the target under test is under a config transition.
config_settings = {
"//command_line_option:compilation_mode": "fastbuild",
"//command_line_option:minimum_os_version": "1234.5678",
},
)

Expand Down

0 comments on commit 68acaa5

Please sign in to comment.