Skip to content

Commit

Permalink
Create a helper rule for selecting a file from outputs of another rul… (
Browse files Browse the repository at this point in the history
#233)

* Create a helper rule for selecting a file from outputs of another rule or a filegroup by subpath

* Add tests

* Address code review comments

* + formatting

Co-authored-by: c-parsons <cparsons@google.com>
  • Loading branch information
irengrig and c-parsons committed Feb 27, 2020
1 parent add8e42 commit 6970e21
Show file tree
Hide file tree
Showing 4 changed files with 76 additions and 0 deletions.
40 changes: 40 additions & 0 deletions rules/select_file.bzl
@@ -0,0 +1,40 @@
"""
select_file() build rule implementation.
Selects a single file from the outputs of some target by given relative path.
"""

def _impl(ctx):
if ctx.attr.subpath and len(ctx.attr.subpath) == 0:
fail("Subpath can not be empty.")

out = None
canonical = ctx.attr.subpath.replace("\\", "/")
for file_ in ctx.attr.srcs.files.to_list():
if file_.path.replace("\\", "/").endswith(canonical):
out = file_
break
if not out:
files_str = ",\n".join([
str(f.path)
for f in ctx.attr.srcs.files.to_list()
])
fail("Can not find specified file in [%s]" % files_str)
return [DefaultInfo(files = depset([out]))]

select_file = rule(
implementation = _impl,
doc = "Selects a single file from the outputs of some target \
by given relative path",
attrs = {
"srcs": attr.label(
allow_files = True,
mandatory = True,
doc = "The target producing the file among other outputs",
),
"subpath": attr.string(
mandatory = True,
doc = "Relative path to the file",
),
},
)
34 changes: 34 additions & 0 deletions tests/select_file/BUILD
@@ -0,0 +1,34 @@
load("//rules:select_file.bzl", "select_file")
load("//rules:diff_test.bzl", "diff_test")

filegroup(
name = "fg",
srcs = [
"subdir/inner.txt",
":select_me.txt",
],
)

select_file(
name = "select_me",
srcs = ":fg",
subpath = "select_me.txt",
)

select_file(
name = "select_inner",
srcs = ":fg",
subpath = "subdir/inner.txt",
)

diff_test(
name = "selected_me",
file1 = ":select_me",
file2 = ":select_me.txt",
)

diff_test(
name = "selected_inner",
file1 = ":select_inner",
file2 = "subdir/inner.txt",
)
1 change: 1 addition & 0 deletions tests/select_file/select_me.txt
@@ -0,0 +1 @@
Outer
1 change: 1 addition & 0 deletions tests/select_file/subdir/inner.txt
@@ -0,0 +1 @@
Inner

0 comments on commit 6970e21

Please sign in to comment.