Respond to review comments

bazelbuild · Oct 18, 2022 · 962eebd · 962eebd
1 parent e96655b
commit 962eebd
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 3 deletions.
diff --git a/gazelle/BUILD b/gazelle/BUILD
@@ -1,7 +1,10 @@
 # The files needed for distribution
 filegroup(
     name = "distribution",
-    srcs = glob(["*"]),
+    srcs = glob(
+        ["*"],
+        allow_empty = True,
+    ),
     visibility = [
         "//:__pkg__",
         "//distribution:__pkg__",

diff --git a/gazelle_setup.bzl b/gazelle_setup.bzl
@@ -17,8 +17,16 @@
 load("@bazel_gazelle//:deps.bzl", "gazelle_dependencies")
 load("@io_bazel_rules_go//go:deps.bzl", "go_register_toolchains", "go_rules_dependencies")
 
-def bazel_skylib_gazelle_plugin_setup():
+def bazel_skylib_gazelle_plugin_setup(go_version = "1.18.7", register_go_toolchains = True):
+    """Set up the dependencies needed by the Gazelle plugin.
+
+    Args:
+      go_version: The version of Go registered as part of the build as a string
+      register_go_toolchains: A boolean indicating whether or not to register the Go toolchains. Defaults to `True`
+    """
     go_rules_dependencies()
-    go_register_toolchains(version = "1.17.1")
+
+    if register_go_toolchains:
+        go_register_toolchains(version = go_version)
 
     gazelle_dependencies()