Create a helper rule for selecting a file from outputs of another rul… #233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e or a filegroup by subpath
irengrig
requested review from
aiuto,
c-parsons,
jin and
laurentlb
as code owners
|
I found that this functionality will be useful, for instance, for rules_foreign_cc users: they build a library with CMake, and then further can select a particular file from the output (we put some of the files into predefined output groups, but we can not know all the cases, so it is not enough in the common case). |
jin
reviewed
Feb 16, 2020
|
Thank you for the review! PTAL |
jin
approved these changes
Feb 18, 2020
jin
approved these changes
Feb 18, 2020
c-parsons
approved these changes
Feb 18, 2020
|
Hi:) We spent time reviewing and improving this - let's merge it? :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…e or a filegroup by subpath