Windows support for build_test #302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FaBrand
reviewed
Jun 2, 2021
FaBrand
reviewed
Jun 16, 2021
meteorcloudy
approved these changes
Sep 24, 2021
tetromino
approved these changes
Sep 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have to point out that the approach used in this PR is a bit hacky as it marks
.batfile as executable on Windows. AFAIK, in order to spawn processes on Windows, Bazel usesCreateProcessWfunction whose docs says that caller should usecmd.exeas the application name and the batch file as one oflpCommandLinearguments. On the other hand, I don't know any Windows flavor that wouldn't run the batch file if it's passed as the application name toCreateProcessW