Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows support for build_test #258

Closed
wants to merge 6 commits into from
Closed

Windows support for build_test #258

wants to merge 6 commits into from

Conversation

stdbug
Copy link
Contributor

@stdbug stdbug commented Jul 22, 2020

Create a portable empty_test rule that always succeeds.
Use that as the test portion fo build_test

@stdbug stdbug requested a review from juliexxia as a code owner July 22, 2020 10:21
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@stdbug
Copy link
Contributor Author

stdbug commented Jul 22, 2020

@googlebot I signed it!

@googlebot
Copy link

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@stdbug
Copy link
Contributor Author

stdbug commented Jul 22, 2020

@googlebot I consent.

@aiuto
Copy link
Contributor

aiuto commented Jul 22, 2020

@sdtwigg You might want to look at this too, WRT to the build test refactoring you did recently.

@stdbug
Copy link
Contributor Author

stdbug commented Aug 3, 2020

@juliexxia Does this need anything else from my side?

@juliexxia
Copy link
Contributor

Apologies for the delay! Adding @meteorcloudy for windows domain knowledge. I think he's OOO until thursday though.

Copy link
Member

@meteorcloudy meteorcloudy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks for the contribution!

@stdbug
Copy link
Contributor Author

stdbug commented Aug 13, 2020

@googlebot I consent.

@aiuto
Copy link
Contributor

aiuto commented Aug 28, 2020

Everyone seems to like this. Can we sort out the CLA part? This sometimes happens if different users push to the same PR. For example, from a corporate account and a personal account.

@FaBrand
Copy link

FaBrand commented Jun 2, 2021

@codeschlosser You could try to close this PR and create a new one with a squashed branch. Since you probably have consented already this could work. I would also be happy to have this in skylib 👍

@stdbug
Copy link
Contributor Author

stdbug commented Jun 2, 2021

@FaBrand, done #302

@stdbug stdbug closed this Jun 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants