Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable unittest.suite to accept partial calls of test rules #276

Merged
merged 3 commits into from Nov 13, 2020

Commits on Nov 12, 2020

  1. Enable unittest.suite to accept partial calls of rules

    This permits using `unittest.suite` with test rules that have nondefault
    attributes, while retaining compatibility with current usage.
    
    For instance, this permits setting a `timeout` on each test in a
    `unittest.suite`.  Previously, all tests in a `unittest.suite` would
    have the default timeout, with no good way to alter this.  This
    made it hard to eliminate all the warnings produced from using the
    `--test_verbose_timeout_warnings` bazel option.
    
    While timeouts were the motivation, the solution here is not specific
    to timeouts. It will permit arbitrary additional arguments to the test
    rules in a `unittest.suite`.
    
    Fixes bazelbuild#98
    dws committed Nov 12, 2020
    Copy the full SHA
    8909370 View commit details
    Browse the repository at this point in the history

Commits on Nov 13, 2020

  1. Respond to review feedback.

    dws committed Nov 13, 2020
    Copy the full SHA
    bdcd227 View commit details
    Browse the repository at this point in the history
  2. Copy the full SHA
    884ce4e View commit details
    Browse the repository at this point in the history