Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update README.md #380

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update README.md #380

wants to merge 1 commit into from

Conversation

BoleynSu
Copy link

If we will remove new_sets, then we should deprecate it instead of sets.

@comius
Copy link
Collaborator

comius commented Sep 13, 2022

I think the docs are correct and sets are the ones deprecated.

@comius comius closed this Sep 13, 2022
@BoleynSu
Copy link
Author

Then we should fix the comments in the source file?

@BoleynSu
Copy link
Author

See https://github.com/bazelbuild/bazel-skylib/blob/main/lib/old_sets.bzl

@comius comius reopened this Sep 15, 2022
@comius
Copy link
Collaborator

comius commented Sep 15, 2022

@tetromino it makes sense to point users to the sets.bzl, right? And get over the new_ and old_, fiasco.

@BoleynSu @comius
Update README.md
b724f70 
If we will remove new_sets, then we should deprecate it instead of sets.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@comius comius comius approved these changes

@tetromino tetromino Awaiting requested review from tetromino tetromino is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@BoleynSu @comius