Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a version consistency check #396

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

tetromino
Copy link
Collaborator

Extract the version from version.bzl using sed.

For MODULE.bazel, we need to use buildifier to avoid confusion between skylib's version and our dependencies' versions.

Extract the version from version.bzl using sed.

For MODULE.bazel, we need to use buildifier to avoid confusion between
skylib's version and our dependencies' versions.
@tetromino
Copy link
Collaborator Author

tetromino commented Sep 8, 2022

NOTE: this is not ready to merge yet - broken with --experimental_enable_bzlmod. See #386 (comment) should be good now

@tetromino tetromino marked this pull request as ready for review September 12, 2022 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant