Expose int- and string-valued build settings as Make variables #440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmeum
force-pushed
the
settings-as-make-variables
branch
2 times, most recently
from
fc848d5
to
27eaaaf
Compare
fmeum
requested review from
brandjon,
tetromino,
comius and
c-mita
as code owners
fmeum
changed the title
While build settings allow for much cleaner flag and setting definitions than `--define`, they have the major drawback that rules need to provide dedicated support for them, which isn't the case for native and most community-maintained rules. This change attempts to bridge this gap by optionally exposing the value of the common build setting types as Make variables to rules that depend on them via the `toolchains` attribute: If the new `make_variable` attribute is set, the value of the flag or setting is available as a Make variable with that. Consistency with pre-defined Make variables is enforced by limiting the character set for `make_variable` values to `[A-Z0-9_]`. The new attribute is also only added to int- and string-valued build settings as the other types lack a canonical stringification.
fmeum
force-pushed
the
settings-as-make-variables
branch
from
27eaaaf
to
6802da8
Compare
|
CC @aranguyen for the configurability point of view |
|
@aranguyen @brandjon Friendly ping, this has come up in Slack again. It does solve a real need. |
gregestren
reviewed
Aug 18, 2023
There was a problem hiding this comment.
Interesting proposal.
This only works for attributes that support make variable expansion, right? So some but not all native attributes. And only Starlark rules that know how factor it in via ctx.var?
The original request is I think asking for a generic mechanism that works everywhere , without rule authors even having to opt in. I realize you're not consciously trying to go that far here, but how do you see this fitting with the broad idea? Do you think the broad idea makes sense?
I'm fairly sympathetic, and offhand think if we wanted to support the broader idea doing so with Starlark flags probably makes sense? But a complete generic variation would have to involve some actual Bazel refactoring?
|
|
||
|
|
||
| <a id="int_setting"></a> | ||
|
|
||
| ## int_setting | ||
|
|
||
| <pre> | ||
| int_setting(<a href="#int_setting-name">name</a>) | ||
| int_setting(<a href="#int_setting-name">name</a>, <a href="#int_setting-make_variable">make_variable</a>) |
There was a problem hiding this comment.
What's the use case for supporting --*_setting, if it can't be set by the user at the command line?
There was a problem hiding this comment.
They can still be set via transitions, which combined with this PR makes it possible to control rule attributes with make variable support via transitions.
|
My aim with this PR is to realize the following:
As a result, users could start replacing I don't have a concrete idea for universal support for build settings that doesn't involve explicit rule opt-in. At this point I'm not even sure whether it would be necessary - moving the Starlark versions of Make variable and location expansion used by the built-in rules to Skylib and packaging them in a very friendly API may actually be good enough. |
|
That all works for me. Thanks. |
gregestren
approved these changes
Aug 21, 2023
|
We'll have to deal with write access reviewers (I'm not. :( ) after my vacation if no one else gets to this first. |
Wyverald
approved these changes
Aug 22, 2023
CauhxMilloy
pushed a commit
to CauhxMilloy/bazel-bats
that referenced
this pull request
Oct 27, 2023
`TemplateVariableInfo` provides a mechanism for custom make variable expansion. `string_flag()` contains a simple (pre-built) way to generate flags. This be used with `config_setting()` and can be set via commandline (without `--define`). `TemplateVariableInfo` support was added to `string_flag()` in bazelbuild/bazel-skylib#440. Many other Bazel target rules support make variable expansion on many attributes (e.g. `env`). This PR adds support for `TemplateVariableInfo` (e.g. via `string_flag()`) to bats bazel test rules on the `env` attribute. Changes: * Adding call to `ctx.expand_make_variables()` in `_bats_test_impl()`. * This is done in addition to (after) expansion for `$(location ...)`. * Updating `:hello_world_test` (which tests `env` attribute usage) to also test flag-driven envs. * Adding `@bazel_skylib` to workspace. * Only used to declare/reference `string_flag()` in `tests/BUILD.bazel`. * While this could have been simply covered by a custom rule (to return a `TemplateVariableInfo`) in a test-specific `.bzl` file, it seemed better to just use the common (external/pre-existing) rule. * Refenced via `git_repository()` as the necessary changes are not yet in a tag/release. * Only affects tests, and thus does not cause any extra transitive dependencies on libraries that use this project. * Misc other changes: * Updating bats-support and bats-assert rules to use `glob()`. * Supports newer versions, which separated out contents into multiple `.bash` files. * More flexible than naming exact file names. * Replacing attribute dict `update()` call with dict concat operator `|`. * Renaming some test cases in `hello_world.bats`. See https://bazel.build/rules/lib/providers/TemplateVariableInfo, https://bazel.build/docs/configurable-attributes, https://bazel.build/reference/be/general#config_setting, https://bazel.build/extending/config#defining-build-settings
filmil
pushed a commit
to filmil/bazel-bats
that referenced
this pull request
Oct 27, 2023
`TemplateVariableInfo` provides a mechanism for custom make variable expansion. `string_flag()` contains a simple (pre-built) way to generate flags. This be used with `config_setting()` and can be set via commandline (without `--define`). `TemplateVariableInfo` support was added to `string_flag()` in bazelbuild/bazel-skylib#440. Many other Bazel target rules support make variable expansion on many attributes (e.g. `env`). This PR adds support for `TemplateVariableInfo` (e.g. via `string_flag()`) to bats bazel test rules on the `env` attribute. Changes: * Adding call to `ctx.expand_make_variables()` in `_bats_test_impl()`. * This is done in addition to (after) expansion for `$(location ...)`. * Updating `:hello_world_test` (which tests `env` attribute usage) to also test flag-driven envs. * Adding `@bazel_skylib` to workspace. * Only used to declare/reference `string_flag()` in `tests/BUILD.bazel`. * While this could have been simply covered by a custom rule (to return a `TemplateVariableInfo`) in a test-specific `.bzl` file, it seemed better to just use the common (external/pre-existing) rule. * Refenced via `git_repository()` as the necessary changes are not yet in a tag/release. * Only affects tests, and thus does not cause any extra transitive dependencies on libraries that use this project. * Misc other changes: * Updating bats-support and bats-assert rules to use `glob()`. * Supports newer versions, which separated out contents into multiple `.bash` files. * More flexible than naming exact file names. * Replacing attribute dict `update()` call with dict concat operator `|`. * Renaming some test cases in `hello_world.bats`. See https://bazel.build/rules/lib/providers/TemplateVariableInfo, https://bazel.build/docs/configurable-attributes, https://bazel.build/reference/be/general#config_setting, https://bazel.build/extending/config#defining-build-settings
cgrindel-self-hosted-renovate bot
added a commit
to cgrindel/bazel-starlib
that referenced
this pull request
Nov 6, 2023
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [bazel_skylib](https://togithub.com/bazelbuild/bazel-skylib) | http_archive | minor | `1.4.2` -> `1.5.0` | --- ### Release Notes <details> <summary>bazelbuild/bazel-skylib (bazel_skylib)</summary> ### [`v1.5.0`](https://togithub.com/bazelbuild/bazel-skylib/releases/tag/1.5.0) [Compare Source](https://togithub.com/bazelbuild/bazel-skylib/compare/1.4.2...1.5.0) ##### What's Changed - Bump rules_pkg dep to 0.9.1 to fix build with --incompatible_config_setting_private_default_visibility by [@​tetromino](https://togithub.com/tetromino) in [bazelbuild/bazel-skylib#452 - Expose int- and string-valued build settings as Make variables by [@​fmeum](https://togithub.com/fmeum) in [bazelbuild/bazel-skylib#440 - Modify actions in order not to need `toolchain` param by [@​kotlaja](https://togithub.com/kotlaja) in [bazelbuild/bazel-skylib#455 - Fix bazel-skylib with Bazel@HEAD by [@​meteorcloudy](https://togithub.com/meteorcloudy) in [bazelbuild/bazel-skylib#462 - versions: Don't fail on Bazel dev builds by [@​fmeum](https://togithub.com/fmeum) in [bazelbuild/bazel-skylib#463 - Add error for empty bzl_library by [@​keith](https://togithub.com/keith) in [bazelbuild/bazel-skylib#457 - Add `doc` param to `unittest.make` by [@​UebelAndre](https://togithub.com/UebelAndre) in [bazelbuild/bazel-skylib#464 - Upgrade rules_go by [@​comius](https://togithub.com/comius) in [bazelbuild/bazel-skylib#460 ##### New Contributors - [@​kotlaja](https://togithub.com/kotlaja) made their first contribution in [bazelbuild/bazel-skylib#455 - [@​keith](https://togithub.com/keith) made their first contribution in [bazelbuild/bazel-skylib#457 **Full Changelog**: bazelbuild/bazel-skylib@1.4.2...1.5.0 ##### MODULE.bazel setup ```starlark bazel_dep(name = "bazel_skylib", version = "1.5.0") ##### If the Gazelle plugin is needed: bazel_dep(name = "bazel_skylib_gazelle_plugin", version = "1.5.0", dev_dependency = True) ``` ##### WORKSPACE setup ```starlark load("@​bazel_tools//tools/build_defs/repo:http.bzl", "http_archive") http_archive( name = "bazel_skylib", sha256 = "cd55a062e763b9349921f0f5db8c3933288dc8ba4f76dd9416aac68acee3cb94" urls = [ "https://mirror.bazel.build/github.com/bazelbuild/bazel-skylib/releases/download/1.5.0/bazel-skylib-1.5.0.tar.gz", "https://github.com/bazelbuild/bazel-skylib/releases/download/1.5.0/bazel-skylib-1.5.0.tar.gz", ], ) load("@​bazel_skylib//:workspace.bzl", "bazel_skylib_workspace") bazel_skylib_workspace() ``` ***Additional WORKSPACE setup for the Gazelle plugin*** ```starlark http_archive( name = "bazel_skylib_gazelle_plugin", sha256 = "747addf3f508186234f6232674dd7786743efb8c68619aece5fb0cac97b8f415", urls = [ "https://mirror.bazel.build/github.com/bazelbuild/bazel-skylib/releases/download/1.5.0/bazel-skylib-gazelle-plugin-1.5.0.tar.gz", "https://github.com/bazelbuild/bazel-skylib/releases/download/1.5.0/bazel-skylib-gazelle-plugin-1.5.0.tar.gz", ], ) load("@​bazel_skylib_gazelle_plugin//:workspace.bzl", "bazel_skylib_gazelle_plugin_workspace") bazel_skylib_gazelle_plugin_workspace() load("@​bazel_skylib_gazelle_plugin//:setup.bzl", "bazel_skylib_gazelle_plugin_setup") bazel_skylib_gazelle_plugin_setup() ``` </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://togithub.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi4xMDAuMCIsInVwZGF0ZWRJblZlciI6IjM2LjEwMC4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Co-authored-by: Self-hosted Renovate Bot <361546+cgrindel-self-hosted-renovate[bot]@users.noreply.github.enterprise.com>
renovate bot
added a commit
to bazel-contrib/rules_bazel_integration_test
that referenced
this pull request
Nov 6, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [bazel_skylib](https://togithub.com/bazelbuild/bazel-skylib) | http_archive | minor | `1.4.2` -> `1.5.0` | --- ### Release Notes <details> <summary>bazelbuild/bazel-skylib (bazel_skylib)</summary> ### [`v1.5.0`](https://togithub.com/bazelbuild/bazel-skylib/releases/tag/1.5.0) [Compare Source](https://togithub.com/bazelbuild/bazel-skylib/compare/1.4.2...1.5.0) #### What's Changed - Bump rules_pkg dep to 0.9.1 to fix build with --incompatible_config_setting_private_default_visibility by [@​tetromino](https://togithub.com/tetromino) in [bazelbuild/bazel-skylib#452 - Expose int- and string-valued build settings as Make variables by [@​fmeum](https://togithub.com/fmeum) in [bazelbuild/bazel-skylib#440 - Modify actions in order not to need `toolchain` param by [@​kotlaja](https://togithub.com/kotlaja) in [bazelbuild/bazel-skylib#455 - Fix bazel-skylib with Bazel@HEAD by [@​meteorcloudy](https://togithub.com/meteorcloudy) in [bazelbuild/bazel-skylib#462 - versions: Don't fail on Bazel dev builds by [@​fmeum](https://togithub.com/fmeum) in [bazelbuild/bazel-skylib#463 - Add error for empty bzl_library by [@​keith](https://togithub.com/keith) in [bazelbuild/bazel-skylib#457 - Add `doc` param to `unittest.make` by [@​UebelAndre](https://togithub.com/UebelAndre) in [bazelbuild/bazel-skylib#464 - Upgrade rules_go by [@​comius](https://togithub.com/comius) in [bazelbuild/bazel-skylib#460 #### New Contributors - [@​kotlaja](https://togithub.com/kotlaja) made their first contribution in [bazelbuild/bazel-skylib#455 - [@​keith](https://togithub.com/keith) made their first contribution in [bazelbuild/bazel-skylib#457 **Full Changelog**: bazelbuild/bazel-skylib@1.4.2...1.5.0 #### WORKSPACE setup load("@​bazel_tools//tools/build_defs/repo:http.bzl", "http_archive") http_archive( name = "bazel_skylib", sha256 = "cd55a062e763b9349921f0f5db8c3933288dc8ba4f76dd9416aac68acee3cb94" urls = [ "https://mirror.bazel.build/github.com/bazelbuild/bazel-skylib/releases/download/1.5.0/bazel-skylib-1.5.0.tar.gz", "https://github.com/bazelbuild/bazel-skylib/releases/download/1.5.0/bazel-skylib-1.5.0.tar.gz", ], ) load("@​bazel_skylib//:workspace.bzl", "bazel_skylib_workspace") bazel_skylib_workspace() ***Additional WORKSPACE setup for the Gazelle plugin*** ```starlark http_archive( name = "bazel_skylib_gazelle_plugin", sha256 = "747addf3f508186234f6232674dd7786743efb8c68619aece5fb0cac97b8f415", urls = [ "https://mirror.bazel.build/github.com/bazelbuild/bazel-skylib/releases/download/1.5.0/bazel-skylib-gazelle-plugin-1.5.0.tar.gz", "https://github.com/bazelbuild/bazel-skylib/releases/download/1.5.0/bazel-skylib-gazelle-plugin-1.5.0.tar.gz", ], ) load("@​bazel_skylib_gazelle_plugin//:workspace.bzl", "bazel_skylib_gazelle_plugin_workspace") bazel_skylib_gazelle_plugin_workspace() load("@​bazel_skylib_gazelle_plugin//:setup.bzl", "bazel_skylib_gazelle_plugin_setup") bazel_skylib_gazelle_plugin_setup() ``` </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/bazel-contrib/rules_bazel_integration_test). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40Ni4wIiwidXBkYXRlZEluVmVyIjoiMzcuNDYuMCIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
renovate bot
added a commit
to kreempuff/rules_unreal_engine
that referenced
this pull request
Nov 6, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [bazel_skylib](https://togithub.com/bazelbuild/bazel-skylib) | http_archive | minor | `1.4.2` -> `1.5.0` | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>bazelbuild/bazel-skylib (bazel_skylib)</summary> ### [`v1.5.0`](https://togithub.com/bazelbuild/bazel-skylib/releases/tag/1.5.0) [Compare Source](https://togithub.com/bazelbuild/bazel-skylib/compare/1.4.2...1.5.0) #### What's Changed - Bump rules_pkg dep to 0.9.1 to fix build with --incompatible_config_setting_private_default_visibility by [@​tetromino](https://togithub.com/tetromino) in [bazelbuild/bazel-skylib#452 - Expose int- and string-valued build settings as Make variables by [@​fmeum](https://togithub.com/fmeum) in [bazelbuild/bazel-skylib#440 - Modify actions in order not to need `toolchain` param by [@​kotlaja](https://togithub.com/kotlaja) in [bazelbuild/bazel-skylib#455 - Fix bazel-skylib with Bazel@HEAD by [@​meteorcloudy](https://togithub.com/meteorcloudy) in [bazelbuild/bazel-skylib#462 - versions: Don't fail on Bazel dev builds by [@​fmeum](https://togithub.com/fmeum) in [bazelbuild/bazel-skylib#463 - Add error for empty bzl_library by [@​keith](https://togithub.com/keith) in [bazelbuild/bazel-skylib#457 - Add `doc` param to `unittest.make` by [@​UebelAndre](https://togithub.com/UebelAndre) in [bazelbuild/bazel-skylib#464 - Upgrade rules_go by [@​comius](https://togithub.com/comius) in [bazelbuild/bazel-skylib#460 #### New Contributors - [@​kotlaja](https://togithub.com/kotlaja) made their first contribution in [bazelbuild/bazel-skylib#455 - [@​keith](https://togithub.com/keith) made their first contribution in [bazelbuild/bazel-skylib#457 **Full Changelog**: bazelbuild/bazel-skylib@1.4.2...1.5.0 #### WORKSPACE setup load("@​bazel_tools//tools/build_defs/repo:http.bzl", "http_archive") http_archive( name = "bazel_skylib", sha256 = "cd55a062e763b9349921f0f5db8c3933288dc8ba4f76dd9416aac68acee3cb94" urls = [ "https://mirror.bazel.build/github.com/bazelbuild/bazel-skylib/releases/download/1.5.0/bazel-skylib-1.5.0.tar.gz", "https://github.com/bazelbuild/bazel-skylib/releases/download/1.5.0/bazel-skylib-1.5.0.tar.gz", ], ) load("@​bazel_skylib//:workspace.bzl", "bazel_skylib_workspace") bazel_skylib_workspace() ***Additional WORKSPACE setup for the Gazelle plugin*** ```starlark http_archive( name = "bazel_skylib_gazelle_plugin", sha256 = "747addf3f508186234f6232674dd7786743efb8c68619aece5fb0cac97b8f415", urls = [ "https://mirror.bazel.build/github.com/bazelbuild/bazel-skylib/releases/download/1.5.0/bazel-skylib-gazelle-plugin-1.5.0.tar.gz", "https://github.com/bazelbuild/bazel-skylib/releases/download/1.5.0/bazel-skylib-gazelle-plugin-1.5.0.tar.gz", ], ) load("@​bazel_skylib_gazelle_plugin//:workspace.bzl", "bazel_skylib_gazelle_plugin_workspace") bazel_skylib_gazelle_plugin_workspace() load("@​bazel_skylib_gazelle_plugin//:setup.bzl", "bazel_skylib_gazelle_plugin_setup") bazel_skylib_gazelle_plugin_setup() ``` </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/kreempuff/rules_unreal_engine). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40Ni4wIiwidXBkYXRlZEluVmVyIjoiMzcuNDYuMCIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==-->
cgrindel-self-hosted-renovate bot
added a commit
to cgrindel/rules_swiftformat
that referenced
this pull request
Nov 6, 2023
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [bazel_skylib](https://togithub.com/bazelbuild/bazel-skylib) | http_archive | minor | `1.4.2` -> `1.5.0` | --- ### Release Notes <details> <summary>bazelbuild/bazel-skylib (bazel_skylib)</summary> ### [`v1.5.0`](https://togithub.com/bazelbuild/bazel-skylib/releases/tag/1.5.0) [Compare Source](https://togithub.com/bazelbuild/bazel-skylib/compare/1.4.2...1.5.0) ##### What's Changed - Bump rules_pkg dep to 0.9.1 to fix build with --incompatible_config_setting_private_default_visibility by [@​tetromino](https://togithub.com/tetromino) in [bazelbuild/bazel-skylib#452 - Expose int- and string-valued build settings as Make variables by [@​fmeum](https://togithub.com/fmeum) in [bazelbuild/bazel-skylib#440 - Modify actions in order not to need `toolchain` param by [@​kotlaja](https://togithub.com/kotlaja) in [bazelbuild/bazel-skylib#455 - Fix bazel-skylib with Bazel@HEAD by [@​meteorcloudy](https://togithub.com/meteorcloudy) in [bazelbuild/bazel-skylib#462 - versions: Don't fail on Bazel dev builds by [@​fmeum](https://togithub.com/fmeum) in [bazelbuild/bazel-skylib#463 - Add error for empty bzl_library by [@​keith](https://togithub.com/keith) in [bazelbuild/bazel-skylib#457 - Add `doc` param to `unittest.make` by [@​UebelAndre](https://togithub.com/UebelAndre) in [bazelbuild/bazel-skylib#464 - Upgrade rules_go by [@​comius](https://togithub.com/comius) in [bazelbuild/bazel-skylib#460 ##### New Contributors - [@​kotlaja](https://togithub.com/kotlaja) made their first contribution in [bazelbuild/bazel-skylib#455 - [@​keith](https://togithub.com/keith) made their first contribution in [bazelbuild/bazel-skylib#457 **Full Changelog**: bazelbuild/bazel-skylib@1.4.2...1.5.0 ##### MODULE.bazel setup ```starlark bazel_dep(name = "bazel_skylib", version = "1.5.0") ##### If the Gazelle plugin is needed: bazel_dep(name = "bazel_skylib_gazelle_plugin", version = "1.5.0", dev_dependency = True) ``` ##### WORKSPACE setup ```starlark load("@​bazel_tools//tools/build_defs/repo:http.bzl", "http_archive") http_archive( name = "bazel_skylib", sha256 = "cd55a062e763b9349921f0f5db8c3933288dc8ba4f76dd9416aac68acee3cb94" urls = [ "https://mirror.bazel.build/github.com/bazelbuild/bazel-skylib/releases/download/1.5.0/bazel-skylib-1.5.0.tar.gz", "https://github.com/bazelbuild/bazel-skylib/releases/download/1.5.0/bazel-skylib-1.5.0.tar.gz", ], ) load("@​bazel_skylib//:workspace.bzl", "bazel_skylib_workspace") bazel_skylib_workspace() ``` ***Additional WORKSPACE setup for the Gazelle plugin*** ```starlark http_archive( name = "bazel_skylib_gazelle_plugin", sha256 = "747addf3f508186234f6232674dd7786743efb8c68619aece5fb0cac97b8f415", urls = [ "https://mirror.bazel.build/github.com/bazelbuild/bazel-skylib/releases/download/1.5.0/bazel-skylib-gazelle-plugin-1.5.0.tar.gz", "https://github.com/bazelbuild/bazel-skylib/releases/download/1.5.0/bazel-skylib-gazelle-plugin-1.5.0.tar.gz", ], ) load("@​bazel_skylib_gazelle_plugin//:workspace.bzl", "bazel_skylib_gazelle_plugin_workspace") bazel_skylib_gazelle_plugin_workspace() load("@​bazel_skylib_gazelle_plugin//:setup.bzl", "bazel_skylib_gazelle_plugin_setup") bazel_skylib_gazelle_plugin_setup() ``` </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://togithub.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi4xMDAuMCIsInVwZGF0ZWRJblZlciI6IjM2LjEwMC4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Co-authored-by: Self-hosted Renovate Bot <361546+cgrindel-self-hosted-renovate[bot]@users.noreply.github.enterprise.com>
cgrindel-self-hosted-renovate bot
added a commit
to cgrindel/rules_swift_package_manager
that referenced
this pull request
Nov 7, 2023
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | bazel_skylib | bazel_dep | minor | `1.4.2` -> `1.5.0` | | [bazel_skylib](https://togithub.com/bazelbuild/bazel-skylib) | http_archive | minor | `1.4.2` -> `1.5.0` | --- ### Release Notes <details> <summary>bazelbuild/bazel-skylib (bazel_skylib)</summary> ### [`v1.5.0`](https://togithub.com/bazelbuild/bazel-skylib/releases/tag/1.5.0) [Compare Source](https://togithub.com/bazelbuild/bazel-skylib/compare/1.4.2...1.5.0) #### What's Changed - Bump rules_pkg dep to 0.9.1 to fix build with --incompatible_config_setting_private_default_visibility by [@​tetromino](https://togithub.com/tetromino) in [bazelbuild/bazel-skylib#452 - Expose int- and string-valued build settings as Make variables by [@​fmeum](https://togithub.com/fmeum) in [bazelbuild/bazel-skylib#440 - Modify actions in order not to need `toolchain` param by [@​kotlaja](https://togithub.com/kotlaja) in [bazelbuild/bazel-skylib#455 - Fix bazel-skylib with Bazel@HEAD by [@​meteorcloudy](https://togithub.com/meteorcloudy) in [bazelbuild/bazel-skylib#462 - versions: Don't fail on Bazel dev builds by [@​fmeum](https://togithub.com/fmeum) in [bazelbuild/bazel-skylib#463 - Add error for empty bzl_library by [@​keith](https://togithub.com/keith) in [bazelbuild/bazel-skylib#457 - Add `doc` param to `unittest.make` by [@​UebelAndre](https://togithub.com/UebelAndre) in [bazelbuild/bazel-skylib#464 - Upgrade rules_go by [@​comius](https://togithub.com/comius) in [bazelbuild/bazel-skylib#460 #### New Contributors - [@​kotlaja](https://togithub.com/kotlaja) made their first contribution in [bazelbuild/bazel-skylib#455 - [@​keith](https://togithub.com/keith) made their first contribution in [bazelbuild/bazel-skylib#457 **Full Changelog**: bazelbuild/bazel-skylib@1.4.2...1.5.0 #### MODULE.bazel setup ```starlark bazel_dep(name = "bazel_skylib", version = "1.5.0") ### If the Gazelle plugin is needed: bazel_dep(name = "bazel_skylib_gazelle_plugin", version = "1.5.0", dev_dependency = True) ``` #### WORKSPACE setup ```starlark load("@​bazel_tools//tools/build_defs/repo:http.bzl", "http_archive") http_archive( name = "bazel_skylib", sha256 = "cd55a062e763b9349921f0f5db8c3933288dc8ba4f76dd9416aac68acee3cb94" urls = [ "https://mirror.bazel.build/github.com/bazelbuild/bazel-skylib/releases/download/1.5.0/bazel-skylib-1.5.0.tar.gz", "https://github.com/bazelbuild/bazel-skylib/releases/download/1.5.0/bazel-skylib-1.5.0.tar.gz", ], ) load("@​bazel_skylib//:workspace.bzl", "bazel_skylib_workspace") bazel_skylib_workspace() ``` ***Additional WORKSPACE setup for the Gazelle plugin*** ```starlark http_archive( name = "bazel_skylib_gazelle_plugin", sha256 = "747addf3f508186234f6232674dd7786743efb8c68619aece5fb0cac97b8f415", urls = [ "https://mirror.bazel.build/github.com/bazelbuild/bazel-skylib/releases/download/1.5.0/bazel-skylib-gazelle-plugin-1.5.0.tar.gz", "https://github.com/bazelbuild/bazel-skylib/releases/download/1.5.0/bazel-skylib-gazelle-plugin-1.5.0.tar.gz", ], ) load("@​bazel_skylib_gazelle_plugin//:workspace.bzl", "bazel_skylib_gazelle_plugin_workspace") bazel_skylib_gazelle_plugin_workspace() load("@​bazel_skylib_gazelle_plugin//:setup.bzl", "bazel_skylib_gazelle_plugin_setup") bazel_skylib_gazelle_plugin_setup() ``` </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://togithub.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi4xMDAuMCIsInVwZGF0ZWRJblZlciI6IjM2LjEwMC4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> --------- Co-authored-by: Self-hosted Renovate Bot <361546+cgrindel-self-hosted-renovate[bot]@users.noreply.github.enterprise.com> Co-authored-by: Chuck Grindel <chuck.grindel@gmail.com>
cgrindel-self-hosted-renovate bot
added a commit
to cgrindel/rules_swift_package_manager
that referenced
this pull request
Nov 8, 2023
…723) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | bazel_skylib_gazelle_plugin | bazel_dep | minor | `1.4.2` -> `1.5.0` | | [bazel_skylib_gazelle_plugin](https://togithub.com/bazelbuild/bazel-skylib) | http_archive | minor | `1.4.2` -> `1.5.0` | --- ### Release Notes <details> <summary>bazelbuild/bazel-skylib (bazel_skylib_gazelle_plugin)</summary> ### [`v1.5.0`](https://togithub.com/bazelbuild/bazel-skylib/releases/tag/1.5.0) [Compare Source](https://togithub.com/bazelbuild/bazel-skylib/compare/1.4.2...1.5.0) #### What's Changed - Bump rules_pkg dep to 0.9.1 to fix build with --incompatible_config_setting_private_default_visibility by [@​tetromino](https://togithub.com/tetromino) in [bazelbuild/bazel-skylib#452 - Expose int- and string-valued build settings as Make variables by [@​fmeum](https://togithub.com/fmeum) in [bazelbuild/bazel-skylib#440 - Modify actions in order not to need `toolchain` param by [@​kotlaja](https://togithub.com/kotlaja) in [bazelbuild/bazel-skylib#455 - Fix bazel-skylib with Bazel@HEAD by [@​meteorcloudy](https://togithub.com/meteorcloudy) in [bazelbuild/bazel-skylib#462 - versions: Don't fail on Bazel dev builds by [@​fmeum](https://togithub.com/fmeum) in [bazelbuild/bazel-skylib#463 - Add error for empty bzl_library by [@​keith](https://togithub.com/keith) in [bazelbuild/bazel-skylib#457 - Add `doc` param to `unittest.make` by [@​UebelAndre](https://togithub.com/UebelAndre) in [bazelbuild/bazel-skylib#464 - Upgrade rules_go by [@​comius](https://togithub.com/comius) in [bazelbuild/bazel-skylib#460 #### New Contributors - [@​kotlaja](https://togithub.com/kotlaja) made their first contribution in [bazelbuild/bazel-skylib#455 - [@​keith](https://togithub.com/keith) made their first contribution in [bazelbuild/bazel-skylib#457 **Full Changelog**: bazelbuild/bazel-skylib@1.4.2...1.5.0 #### MODULE.bazel setup ```starlark bazel_dep(name = "bazel_skylib", version = "1.5.0") ### If the Gazelle plugin is needed: bazel_dep(name = "bazel_skylib_gazelle_plugin", version = "1.5.0", dev_dependency = True) ``` #### WORKSPACE setup ```starlark load("@​bazel_tools//tools/build_defs/repo:http.bzl", "http_archive") http_archive( name = "bazel_skylib", sha256 = "cd55a062e763b9349921f0f5db8c3933288dc8ba4f76dd9416aac68acee3cb94" urls = [ "https://mirror.bazel.build/github.com/bazelbuild/bazel-skylib/releases/download/1.5.0/bazel-skylib-1.5.0.tar.gz", "https://github.com/bazelbuild/bazel-skylib/releases/download/1.5.0/bazel-skylib-1.5.0.tar.gz", ], ) load("@​bazel_skylib//:workspace.bzl", "bazel_skylib_workspace") bazel_skylib_workspace() ``` ***Additional WORKSPACE setup for the Gazelle plugin*** ```starlark http_archive( name = "bazel_skylib_gazelle_plugin", sha256 = "747addf3f508186234f6232674dd7786743efb8c68619aece5fb0cac97b8f415", urls = [ "https://mirror.bazel.build/github.com/bazelbuild/bazel-skylib/releases/download/1.5.0/bazel-skylib-gazelle-plugin-1.5.0.tar.gz", "https://github.com/bazelbuild/bazel-skylib/releases/download/1.5.0/bazel-skylib-gazelle-plugin-1.5.0.tar.gz", ], ) load("@​bazel_skylib_gazelle_plugin//:workspace.bzl", "bazel_skylib_gazelle_plugin_workspace") bazel_skylib_gazelle_plugin_workspace() load("@​bazel_skylib_gazelle_plugin//:setup.bzl", "bazel_skylib_gazelle_plugin_setup") bazel_skylib_gazelle_plugin_setup() ``` </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://togithub.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi4xMDAuMCIsInVwZGF0ZWRJblZlciI6IjM2LjEwMC4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> --------- Co-authored-by: Self-hosted Renovate Bot <361546+cgrindel-self-hosted-renovate[bot]@users.noreply.github.enterprise.com> Co-authored-by: Chuck Grindel <chuck.grindel@gmail.com>
anakinxc
pushed a commit
to secretflow/spu
that referenced
this pull request
Jan 12, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [bazel_skylib](https://togithub.com/bazelbuild/bazel-skylib) | http_archive | minor | `1.3.0` -> `1.5.0` | --- ### Release Notes <details> <summary>bazelbuild/bazel-skylib (bazel_skylib)</summary> ### [`v1.5.0`](https://togithub.com/bazelbuild/bazel-skylib/releases/tag/1.5.0) [Compare Source](https://togithub.com/bazelbuild/bazel-skylib/compare/1.4.2...1.5.0) #### What's Changed - Bump rules_pkg dep to 0.9.1 to fix build with --incompatible_config_setting_private_default_visibility by [@​tetromino](https://togithub.com/tetromino) in [bazelbuild/bazel-skylib#452 - Expose int- and string-valued build settings as Make variables by [@​fmeum](https://togithub.com/fmeum) in [bazelbuild/bazel-skylib#440 - Modify actions in order not to need `toolchain` param by [@​kotlaja](https://togithub.com/kotlaja) in [bazelbuild/bazel-skylib#455 - Fix bazel-skylib with Bazel@HEAD by [@​meteorcloudy](https://togithub.com/meteorcloudy) in [bazelbuild/bazel-skylib#462 - versions: Don't fail on Bazel dev builds by [@​fmeum](https://togithub.com/fmeum) in [bazelbuild/bazel-skylib#463 - Add error for empty bzl_library by [@​keith](https://togithub.com/keith) in [bazelbuild/bazel-skylib#457 - Add `doc` param to `unittest.make` by [@​UebelAndre](https://togithub.com/UebelAndre) in [bazelbuild/bazel-skylib#464 - Upgrade rules_go by [@​comius](https://togithub.com/comius) in [bazelbuild/bazel-skylib#460 #### New Contributors - [@​kotlaja](https://togithub.com/kotlaja) made their first contribution in [bazelbuild/bazel-skylib#455 - [@​keith](https://togithub.com/keith) made their first contribution in [bazelbuild/bazel-skylib#457 **Full Changelog**: bazelbuild/bazel-skylib@1.4.2...1.5.0 #### MODULE.bazel setup ```starlark bazel_dep(name = "bazel_skylib", version = "1.5.0") ### If the Gazelle plugin is needed: bazel_dep(name = "bazel_skylib_gazelle_plugin", version = "1.5.0", dev_dependency = True) ``` #### WORKSPACE setup ```starlark load("@​bazel_tools//tools/build_defs/repo:http.bzl", "http_archive") http_archive( name = "bazel_skylib", sha256 = "cd55a062e763b9349921f0f5db8c3933288dc8ba4f76dd9416aac68acee3cb94" urls = [ "https://mirror.bazel.build/github.com/bazelbuild/bazel-skylib/releases/download/1.5.0/bazel-skylib-1.5.0.tar.gz", "https://github.com/bazelbuild/bazel-skylib/releases/download/1.5.0/bazel-skylib-1.5.0.tar.gz", ], ) load("@​bazel_skylib//:workspace.bzl", "bazel_skylib_workspace") bazel_skylib_workspace() ``` ***Additional WORKSPACE setup for the Gazelle plugin*** ```starlark http_archive( name = "bazel_skylib_gazelle_plugin", sha256 = "747addf3f508186234f6232674dd7786743efb8c68619aece5fb0cac97b8f415", urls = [ "https://mirror.bazel.build/github.com/bazelbuild/bazel-skylib/releases/download/1.5.0/bazel-skylib-gazelle-plugin-1.5.0.tar.gz", "https://github.com/bazelbuild/bazel-skylib/releases/download/1.5.0/bazel-skylib-gazelle-plugin-1.5.0.tar.gz", ], ) load("@​bazel_skylib_gazelle_plugin//:workspace.bzl", "bazel_skylib_gazelle_plugin_workspace") bazel_skylib_gazelle_plugin_workspace() load("@​bazel_skylib_gazelle_plugin//:setup.bzl", "bazel_skylib_gazelle_plugin_setup") bazel_skylib_gazelle_plugin_setup() ``` ### [`v1.4.2`](https://togithub.com/bazelbuild/bazel-skylib/releases/tag/1.4.2) [Compare Source](https://togithub.com/bazelbuild/bazel-skylib/compare/1.4.1...1.4.2) Release 1.4.2 Bugfix release: fixes `build_test` to respect `target_compatible_with` ([#​448](https://togithub.com/bazelbuild/bazel-skylib/issues/448)) **New Features** - `bzl_library` allows `.scl` files (new Starlark dialect loadable by Bazel at HEAD with `--experimental_enable_scl_dialect`) **Contributors** Alexandre Rostovtsev, UebelAndre, Vertexwahn, Xavier Bonaventura **WORKSPACE setup** ```starlark load("@​bazel_tools//tools/build_defs/repo:http.bzl", "http_archive") http_archive( name = "bazel_skylib", sha256 = "66ffd9315665bfaafc96b52278f57c7e2dd09f5ede279ea6d39b2be471e7e3aa", urls = [ "https://mirror.bazel.build/github.com/bazelbuild/bazel-skylib/releases/download/1.4.2/bazel-skylib-1.4.2.tar.gz", "https://github.com/bazelbuild/bazel-skylib/releases/download/1.4.2/bazel-skylib-1.4.2.tar.gz", ], ) load("@​bazel_skylib//:workspace.bzl", "bazel_skylib_workspace") bazel_skylib_workspace() ``` ***Additional WORKSPACE setup for the Gazelle plugin*** ```starlark http_archive( name = "bazel_skylib_gazelle_plugin", sha256 = "3327005dbc9e49cc39602fb46572525984f7119a9c6ffe5ed69fbe23db7c1560", urls = [ "https://mirror.bazel.build/github.com/bazelbuild/bazel-skylib/releases/download/1.4.2/bazel-skylib-gazelle-plugin-1.4.2.tar.gz", "https://github.com/bazelbuild/bazel-skylib/releases/download/1.4.2/bazel-skylib-gazelle-plugin-1.4.2.tar.gz", ], ) load("@​bazel_skylib_gazelle_plugin//:workspace.bzl", "bazel_skylib_gazelle_plugin_workspace") bazel_skylib_gazelle_plugin_workspace() load("@​bazel_skylib_gazelle_plugin//:setup.bzl", "bazel_skylib_gazelle_plugin_setup") bazel_skylib_gazelle_plugin_setup() ``` **MODULE.bazel setup** ```starlark bazel_dep(name = "bazel_skylib", version = "1.4.2") ``` And for the Gazelle plugin: ```starlark bazel_dep(name = "bazel_skylib_gazelle_plugin", version = "1.4.2", dev_dependency = True) ``` **Using the rules** See [the source](https://togithub.com/bazelbuild/bazel-skylib/tree/1.4.2). ### [`v1.4.1`](https://togithub.com/bazelbuild/bazel-skylib/releases/tag/1.4.1) [Compare Source](https://togithub.com/bazelbuild/bazel-skylib/compare/1.4.0...1.4.1) Release 1.4.1 Bugfix release: fixes gazelle plugin failure with `--incompatible_disallow_empty_glob` ([#​431](https://togithub.com/bazelbuild/bazel-skylib/issues/431)) and (for released versions) with `--incompatible_disable_starlark_host_transitions` ([#​433](https://togithub.com/bazelbuild/bazel-skylib/issues/433)). **Contributors** Alexandre Rostovtsev, Chuck Grindel **WORKSPACE setup** ```starlark load("@​bazel_tools//tools/build_defs/repo:http.bzl", "http_archive") http_archive( name = "bazel_skylib", sha256 = "b8a1527901774180afc798aeb28c4634bdccf19c4d98e7bdd1ce79d1fe9aaad7", urls = [ "https://mirror.bazel.build/github.com/bazelbuild/bazel-skylib/releases/download/1.4.1/bazel-skylib-1.4.1.tar.gz", "https://github.com/bazelbuild/bazel-skylib/releases/download/1.4.1/bazel-skylib-1.4.1.tar.gz", ], ) load("@​bazel_skylib//:workspace.bzl", "bazel_skylib_workspace") bazel_skylib_workspace() ``` ***Additional WORKSPACE setup for the Gazelle plugin*** ```starlark http_archive( name = "bazel_skylib_gazelle_plugin", sha256 = "0a466b61f331585f06ecdbbf2480b9edf70e067a53f261e0596acd573a7d2dc3", urls = [ "https://mirror.bazel.build/github.com/bazelbuild/bazel-skylib/releases/download/1.4.1/bazel-skylib-gazelle-plugin-1.4.1.tar.gz", "https://github.com/bazelbuild/bazel-skylib/releases/download/1.4.1/bazel-skylib-gazelle-plugin-1.4.1.tar.gz", ], ) load("@​bazel_skylib_gazelle_plugin//:workspace.bzl", "bazel_skylib_gazelle_plugin_workspace") bazel_skylib_gazelle_plugin_workspace() load("@​bazel_skylib_gazelle_plugin//:setup.bzl", "bazel_skylib_gazelle_plugin_setup") bazel_skylib_gazelle_plugin_setup() ``` **MODULE.bazel setup** ```starlark bazel_dep(name = "bazel_skylib", version = "1.4.1") ``` And for the Gazelle plugin: ```starlark bazel_dep(name = "bazel_skylib_gazelle_plugin", version = "1.4.1", dev_dependency = True) ``` **Using the rules** See [the source](https://togithub.com/bazelbuild/bazel-skylib/tree/1.4.1). ### [`v1.4.0`](https://togithub.com/bazelbuild/bazel-skylib/releases/tag/1.4.0) [Compare Source](https://togithub.com/bazelbuild/bazel-skylib/compare/1.3.0...1.4.0) Release 1.4.0 **New Features** - The Gazelle plugin is marked stable for general use ([#​400](https://togithub.com/bazelbuild/bazel-skylib/issues/400), [#​424](https://togithub.com/bazelbuild/bazel-skylib/issues/424)) **Other Notable Changes** - copy_file/copy_directory again allow sandboxing ([#​392](https://togithub.com/bazelbuild/bazel-skylib/issues/392)) **Contributors** Alexandre Rostovtsev, Nick Gooding, Simon Stewart, Xùdōng Yáng **WORKSPACE setup** ```starlark load("@​bazel_tools//tools/build_defs/repo:http.bzl", "http_archive") http_archive( name = "bazel_skylib", sha256 = "f24ab666394232f834f74d19e2ff142b0af17466ea0c69a3f4c276ee75f6efce", urls = [ "https://mirror.bazel.build/github.com/bazelbuild/bazel-skylib/releases/download/1.4.0/bazel-skylib-1.4.0.tar.gz", "https://github.com/bazelbuild/bazel-skylib/releases/download/1.4.0/bazel-skylib-1.4.0.tar.gz", ], ) load("@​bazel_skylib//:workspace.bzl", "bazel_skylib_workspace") bazel_skylib_workspace() ``` ***Additional WORKSPACE setup for the Gazelle plugin*** ```starlark http_archive( name = "bazel_skylib_gazelle_plugin", sha256 = "04182233284fcb6545d36b94248fe28186b4d9d574c4131d6a511d5aeb278c46", urls = [ "https://mirror.bazel.build/github.com/bazelbuild/bazel-skylib/releases/download/1.4.0/bazel-skylib-gazelle-plugin-1.4.0.tar.gz", "https://github.com/bazelbuild/bazel-skylib/releases/download/1.4.0/bazel-skylib-gazelle-plugin-1.4.0.tar.gz", ], ) load("@​bazel_skylib_gazelle_plugin//:workspace.bzl", "bazel_skylib_gazelle_plugin_workspace") bazel_skylib_gazelle_plugin_workspace() load("@​bazel_skylib_gazelle_plugin//:setup.bzl", "bazel_skylib_gazelle_plugin_setup") bazel_skylib_gazelle_plugin_setup() ``` **MODULE.bazel setup** ```starlark bazel_dep(name = "bazel_skylib", version = "1.4.0") ``` And for the Gazelle plugin: ```starlark bazel_dep(name = "bazel_skylib_gazelle_plugin", version = "1.4.0", dev_dependency = True) ``` **Using the rules** See [the source](https://togithub.com/bazelbuild/bazel-skylib/tree/1.4.0). </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/secretflow/spu). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xMjcuMCIsInVwZGF0ZWRJblZlciI6IjM3LjEyNy4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
tetromino
added a commit
to tetromino/bazel-skylib
that referenced
this pull request
Jan 19, 2024
Internal linter complains about it since bazelbuild#440.
alexeagle
pushed a commit
to aspect-build/rules_py
that referenced
this pull request
Feb 2, 2024
…243) [](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [bazel_skylib_gazelle_plugin](https://togithub.com/bazelbuild/bazel-skylib) | http_archive | minor | `1.4.2` -> `1.5.0` | --- ### Release Notes <details> <summary>bazelbuild/bazel-skylib (bazel_skylib_gazelle_plugin)</summary> ### [`v1.5.0`](https://togithub.com/bazelbuild/bazel-skylib/releases/tag/1.5.0) [Compare Source](https://togithub.com/bazelbuild/bazel-skylib/compare/1.4.2...1.5.0) #### What's Changed - Bump rules_pkg dep to 0.9.1 to fix build with --incompatible_config_setting_private_default_visibility by [@​tetromino](https://togithub.com/tetromino) in [bazelbuild/bazel-skylib#452 - Expose int- and string-valued build settings as Make variables by [@​fmeum](https://togithub.com/fmeum) in [bazelbuild/bazel-skylib#440 - Modify actions in order not to need `toolchain` param by [@​kotlaja](https://togithub.com/kotlaja) in [bazelbuild/bazel-skylib#455 - Fix bazel-skylib with Bazel@HEAD by [@​meteorcloudy](https://togithub.com/meteorcloudy) in [bazelbuild/bazel-skylib#462 - versions: Don't fail on Bazel dev builds by [@​fmeum](https://togithub.com/fmeum) in [bazelbuild/bazel-skylib#463 - Add error for empty bzl_library by [@​keith](https://togithub.com/keith) in [bazelbuild/bazel-skylib#457 - Add `doc` param to `unittest.make` by [@​UebelAndre](https://togithub.com/UebelAndre) in [bazelbuild/bazel-skylib#464 - Upgrade rules_go by [@​comius](https://togithub.com/comius) in [bazelbuild/bazel-skylib#460 #### New Contributors - [@​kotlaja](https://togithub.com/kotlaja) made their first contribution in [bazelbuild/bazel-skylib#455 - [@​keith](https://togithub.com/keith) made their first contribution in [bazelbuild/bazel-skylib#457 **Full Changelog**: bazelbuild/bazel-skylib@1.4.2...1.5.0 #### MODULE.bazel setup ```starlark bazel_dep(name = "bazel_skylib", version = "1.5.0") ### If the Gazelle plugin is needed: bazel_dep(name = "bazel_skylib_gazelle_plugin", version = "1.5.0", dev_dependency = True) ``` #### WORKSPACE setup ```starlark load("@​bazel_tools//tools/build_defs/repo:http.bzl", "http_archive") http_archive( name = "bazel_skylib", sha256 = "cd55a062e763b9349921f0f5db8c3933288dc8ba4f76dd9416aac68acee3cb94" urls = [ "https://mirror.bazel.build/github.com/bazelbuild/bazel-skylib/releases/download/1.5.0/bazel-skylib-1.5.0.tar.gz", "https://github.com/bazelbuild/bazel-skylib/releases/download/1.5.0/bazel-skylib-1.5.0.tar.gz", ], ) load("@​bazel_skylib//:workspace.bzl", "bazel_skylib_workspace") bazel_skylib_workspace() ``` ***Additional WORKSPACE setup for the Gazelle plugin*** ```starlark http_archive( name = "bazel_skylib_gazelle_plugin", sha256 = "747addf3f508186234f6232674dd7786743efb8c68619aece5fb0cac97b8f415", urls = [ "https://mirror.bazel.build/github.com/bazelbuild/bazel-skylib/releases/download/1.5.0/bazel-skylib-gazelle-plugin-1.5.0.tar.gz", "https://github.com/bazelbuild/bazel-skylib/releases/download/1.5.0/bazel-skylib-gazelle-plugin-1.5.0.tar.gz", ], ) load("@​bazel_skylib_gazelle_plugin//:workspace.bzl", "bazel_skylib_gazelle_plugin_workspace") bazel_skylib_gazelle_plugin_workspace() load("@​bazel_skylib_gazelle_plugin//:setup.bzl", "bazel_skylib_gazelle_plugin_setup") bazel_skylib_gazelle_plugin_setup() ``` </details> --- ### Configuration 📅 **Schedule**: Branch creation - "before 4am on Monday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/aspect-build/rules_py). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xMjcuMCIsInVwZGF0ZWRJblZlciI6IjM3LjEyNy4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
alexeagle
added a commit
to aspect-build/rules_py
that referenced
this pull request
Feb 15, 2024
](https://renovatebot.com){kind=link}
[](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | bazel_skylib | bazel_dep | minor | `1.4.2` -> `1.5.0` | | [bazel_skylib](https://togithub.com/bazelbuild/bazel-skylib) | http_archive | minor | `1.4.2` -> `1.5.0` | --- ### Release Notes <details> <summary>bazelbuild/bazel-skylib (bazel_skylib)</summary> ### [`v1.5.0`](https://togithub.com/bazelbuild/bazel-skylib/releases/tag/1.5.0) [Compare Source](https://togithub.com/bazelbuild/bazel-skylib/compare/1.4.2...1.5.0) #### What's Changed - Bump rules_pkg dep to 0.9.1 to fix build with --incompatible_config_setting_private_default_visibility by [@​tetromino](https://togithub.com/tetromino) in [bazelbuild/bazel-skylib#452 - Expose int- and string-valued build settings as Make variables by [@​fmeum](https://togithub.com/fmeum) in [bazelbuild/bazel-skylib#440 - Modify actions in order not to need `toolchain` param by [@​kotlaja](https://togithub.com/kotlaja) in [bazelbuild/bazel-skylib#455 - Fix bazel-skylib with Bazel@HEAD by [@​meteorcloudy](https://togithub.com/meteorcloudy) in [bazelbuild/bazel-skylib#462 - versions: Don't fail on Bazel dev builds by [@​fmeum](https://togithub.com/fmeum) in [bazelbuild/bazel-skylib#463 - Add error for empty bzl_library by [@​keith](https://togithub.com/keith) in [bazelbuild/bazel-skylib#457 - Add `doc` param to `unittest.make` by [@​UebelAndre](https://togithub.com/UebelAndre) in [bazelbuild/bazel-skylib#464 - Upgrade rules_go by [@​comius](https://togithub.com/comius) in [bazelbuild/bazel-skylib#460 #### New Contributors - [@​kotlaja](https://togithub.com/kotlaja) made their first contribution in [bazelbuild/bazel-skylib#455 - [@​keith](https://togithub.com/keith) made their first contribution in [bazelbuild/bazel-skylib#457 **Full Changelog**: bazelbuild/bazel-skylib@1.4.2...1.5.0 #### MODULE.bazel setup ```starlark bazel_dep(name = "bazel_skylib", version = "1.5.0") ### If the Gazelle plugin is needed: bazel_dep(name = "bazel_skylib_gazelle_plugin", version = "1.5.0", dev_dependency = True) ``` #### WORKSPACE setup ```starlark load("@​bazel_tools//tools/build_defs/repo:http.bzl", "http_archive") http_archive( name = "bazel_skylib", sha256 = "cd55a062e763b9349921f0f5db8c3933288dc8ba4f76dd9416aac68acee3cb94" urls = [ "https://mirror.bazel.build/github.com/bazelbuild/bazel-skylib/releases/download/1.5.0/bazel-skylib-1.5.0.tar.gz", "https://github.com/bazelbuild/bazel-skylib/releases/download/1.5.0/bazel-skylib-1.5.0.tar.gz", ], ) load("@​bazel_skylib//:workspace.bzl", "bazel_skylib_workspace") bazel_skylib_workspace() ``` ***Additional WORKSPACE setup for the Gazelle plugin*** ```starlark http_archive( name = "bazel_skylib_gazelle_plugin", sha256 = "747addf3f508186234f6232674dd7786743efb8c68619aece5fb0cac97b8f415", urls = [ "https://mirror.bazel.build/github.com/bazelbuild/bazel-skylib/releases/download/1.5.0/bazel-skylib-gazelle-plugin-1.5.0.tar.gz", "https://github.com/bazelbuild/bazel-skylib/releases/download/1.5.0/bazel-skylib-gazelle-plugin-1.5.0.tar.gz", ], ) load("@​bazel_skylib_gazelle_plugin//:workspace.bzl", "bazel_skylib_gazelle_plugin_workspace") bazel_skylib_gazelle_plugin_workspace() load("@​bazel_skylib_gazelle_plugin//:setup.bzl", "bazel_skylib_gazelle_plugin_setup") bazel_skylib_gazelle_plugin_setup() ``` </details> --- ### Configuration 📅 **Schedule**: Branch creation - "before 4am on Monday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/aspect-build/rules_py). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy41OS44IiwidXBkYXRlZEluVmVyIjoiMzcuODEuMyIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==--> --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Alex Eagle <alex@aspect.dev>
CauhxMilloy
added a commit
to CauhxMilloy/bazel-bats
that referenced
this pull request
May 11, 2024
Cleaning up TODO for replacing `git_repository()` with `http_archive()` once tag is available. Setting to version 1.5.0, which is the next release which contained the necessary changes (bazelbuild/bazel-skylib#440). See https://github.com/bazelbuild/bazel-skylib/releases/tag/1.5.0.
filmil
pushed a commit
to filmil/bazel-bats
that referenced
this pull request
May 11, 2024
Cleaning up TODO for replacing `git_repository()` with `http_archive()` once tag is available. Setting to version 1.5.0, which is the next release which contained the necessary changes (bazelbuild/bazel-skylib#440). See https://github.com/bazelbuild/bazel-skylib/releases/tag/1.5.0.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While build settings allow for much cleaner flag and setting definitions than
--define, they have the major drawback that rules need to provide dedicated support for them, which isn't the case for native and most community-maintained rules.This change attempts to bridge this gap by optionally exposing the value of the common build setting types as Make variables to rules that depend on them via the
toolchainsattribute: If the newmake_variableattribute is set, the value of the flag or setting is available as a Make variable with that.Consistency with pre-defined Make variables is enforced by limiting the character set for
make_variablevalues to[A-Z0-9_]. The new attribute is also only added to int- and string-valued build settings as the other types lack a canonical stringification.Work towards bazelbuild/bazel#14859