Add env and env_inherit to native_binary and native_test (using @bazel_features)
#484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
redsun82
requested review from
brandjon,
tetromino,
comius and
c-mita
as code owners
redsun82
changed the title
env and env_inherit to native_binary and native_testenv and env_inherit to native_binary and native_test (using @bazel_features)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This relies on the
RunEnvironmentInfothat was introduced in bazel 5.3.0. To keep the library compatible with previous versions,bazel_featuresis used.To make it possible to run CI and update the docs without all the dependencies from
@bazel_features(some of which would be private and not visible to the doc generation rule), abazel_features_stubdirectory is introduced which remains unused when using a released version of the library (it gets removed byMODULE.bazel-remove-override.patch).Also, this requires a user to do an additional
WORKSPACEsetup step if they need to usenative_binary.bzland they are not using bzlmod.Closes #409