Support custom mnemonic and progress_message
#491
+199
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshua-k-harris
requested review from
brandjon,
tetromino,
comius and
c-mita
as code owners
joshua-k-harris
force-pushed
the
custom-mnemonics
branch
from
61f1274
to
2c79484
Compare
tetromino
requested changes
Mar 14, 2024
There was a problem hiding this comment.
Looks reasonable overall.
Out of curiosity, why in the macros is the order of args progress_message, mnemonic instead of the other way around (alphabetically)?
It would probably be good to add test for this. There isn't any conveniet way to test the progress message, but we can test the mnemonic via skylib's own unittest.bzl (retrieve via analysistest.target_actions(env)[0].mnemonic)
joshua-k-harris
force-pushed
the
custom-mnemonics
branch
3 times, most recently
from
73b8807
to
6979328
Compare
|
cc @brandjon Setting mnemonics from targets is something we had huge problems with internally. |
joshua-k-harris
force-pushed
the
custom-mnemonics
branch
from
6979328
to
f7cf6a6
Compare
Does this impact the inclusion of this change or can you restrict the use of the attributes internally? |
joshua-k-harris
force-pushed
the
custom-mnemonics
branch
3 times, most recently
from
f7cf6a6
to
4426716
Compare
Adds support for custom 'mnemonic' and 'progress_message' attributes for 'copy_file', 'copy_directory' and 'run_binary' rules.
Adds tests to verify custom mnemonics set on `copy_file`, `copy_directory` and `run_binary`.
joshua-k-harris
force-pushed
the
custom-mnemonics
branch
from
4426716
to
63a140f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for adding a custom
mnemonicandprogress_messageforcopy_file,copy_directoryandrun_binaryrules.Addresses #489 and #426