Support passing arguments to run_binary via param file #492
+20
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vejbomar
requested review from
brandjon,
tetromino,
comius and
c-mita
as code owners
Allows to use run_binary in the case when the size of the command line can grow longer than the maximum size allowed by the system.
vejbomar
force-pushed
the
run-binary-param-files
branch
from
e59f67b
to
454d517
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows to use
run_binaryin the case when the size of the command line can grow longer than the maximum size allowed by the system. We're currently hitting command line limits in our build setup.Implementation inspired from Scala rules.